Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session: support non-transactional insert statements #38799

Merged
merged 9 commits into from
Nov 3, 2022
Merged

session: support non-transactional insert statements #38799

merged 9 commits into from
Nov 3, 2022

Conversation

you06
Copy link
Contributor

@you06 you06 commented Nov 1, 2022

What problem does this PR solve?

Issue Number: ref #33485
Problem Summary:

What is changed and how it works?

This PR supports non-transaction insert statements.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Support non-transaction insert statements.

@you06 you06 requested a review from ekexium November 1, 2022 10:59
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 1, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • ekexium

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 1, 2022
ekexium
ekexium reviewed Nov 1, 2022
View reviewed changes
Copy link
Member

@ekexium ekexium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add a constraint that the source table cannot be the dest table?

session/nontransactional.go Outdated Show resolved Hide resolved
you06 added 3 commits November 1, 2022 21:25
@you06
wip
bcde60a 
Signed-off-by: you06 <[email protected]>
@you06
add test
f3384d1 
Signed-off-by: you06 <[email protected]>
@you06
address comment
359b1e5 
Signed-off-by: you06 <[email protected]>
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 1, 2022
ekexium
ekexium approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@ekexium ekexium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add a constraint that the source table cannot be the dest table?

We can discuss it later

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 2, 2022
@ekexium ekexium requested a review from cfzjywxk November 2, 2022 10:21
@you06
Copy link
Contributor Author

you06 commented Nov 2, 2022

I just added the test cases for insert on duplicate key update statements.

@you06
Copy link
Contributor Author

you06 commented Nov 2, 2022

Shall we add a constraint that the source table cannot be the dest table?

Disable this use case by now.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 2, 2022
@sticnarf
Copy link
Contributor

sticnarf commented Nov 3, 2022

/run-all-tests

@you06
fix bazel
3907a97 
Signed-off-by: you06 <[email protected]>
@sticnarf
Copy link
Contributor

sticnarf commented Nov 3, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3907a97

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 3, 2022
@you06
Copy link
Contributor Author

you06 commented Nov 3, 2022

/run-mysql-test

@you06
Copy link
Contributor Author

you06 commented Nov 3, 2022

/run-mysql-test

4 similar comments
@you06
Copy link
Contributor Author

you06 commented Nov 3, 2022

/run-mysql-test

@you06
Copy link
Contributor Author

you06 commented Nov 3, 2022

/run-mysql-test

@you06
Copy link
Contributor Author

you06 commented Nov 3, 2022

/run-mysql-test

@you06
Copy link
Contributor Author

you06 commented Nov 3, 2022

/run-mysql-test

@you06
Copy link
Contributor Author

you06 commented Nov 3, 2022

/run-mysql-test tidb-test=pr/2007

@ti-chi-bot ti-chi-bot merged commit d7bd49a into pingcap:master Nov 3, 2022
@you06 you06 deleted the insert-nt branch November 3, 2022 18:28
@sre-bot
Copy link
Contributor

sre-bot commented Nov 3, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟥 failed 8, success 9, total 17 6 min 13 sec New failing
idc-jenkins-ci-tidb/common-test 🔴 failed 2, success 9, total 11 5 min 5 sec Existing failure
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 22 min Existing passed
idc-jenkins-ci/integration-cdc-test 🟢 all 39 tests passed 21 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 7 min 8 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 6 min 41 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 12 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 11 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 2 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekexium ekexium ekexium approved these changes

@cfzjywxk cfzjywxk cfzjywxk approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@you06 @ti-chi-bot @sticnarf @sre-bot @cfzjywxk @ekexium