Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extension: add extension API to listen stmt events #38789

Merged
merged 9 commits into from
Nov 7, 2022
Merged

extension: add extension API to listen stmt events #38789

merged 9 commits into from
Nov 7, 2022

Conversation

lcwangchao
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #38788

What is changed and how it works?

add OnStmtEvent to SessionHandler to handle stmt events

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@lcwangchao lcwangchao requested a review from a team as a code owner November 1, 2022 06:50
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 1, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 1, 2022
@lcwangchao lcwangchao changed the title extension: add extension API for stmt events extension: add extension API to listen stmt events Nov 1, 2022
bb7133
bb7133 approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 4, 2022
xhebox
xhebox reviewed Nov 7, 2022
View reviewed changes
sessionctx/variable/session.go Show resolved Hide resolved
server/conn.go Outdated Show resolved Hide resolved
sessionctx/stmtctx/stmtctx.go Outdated
@@ -104,6 +104,8 @@ func (warn *SQLWarn) UnmarshalJSON(data []byte) error {
// StatementContext contains variables for a statement.
// It should be reset before executing a statement.
type StatementContext struct {
// Expired will be true when a new query comes but the current StmtCtx is not reset yet
Expired bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe we can hook RestStatementContext? And use NotReset bool instead of hooking Expired = true everywhere.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not easy to do this because after the first statement "reset" a stmt context and the stmt finished, we should change the NotReset to false before RestStatementContext of the next statement. It is the same of the current implement

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still doubts this will race somehow. Maybe it is enough to copy some of the property instead of directly &sc. Primitives like string or integer have little performance impact.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 7, 2022
@lcwangchao
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ff9daff

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 7, 2022
@ti-chi-bot ti-chi-bot merged commit dc9b691 into pingcap:master Nov 7, 2022
@lcwangchao lcwangchao deleted the extension_stmt_events branch November 7, 2022 08:05
@sre-bot
Copy link
Contributor

sre-bot commented Nov 7, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/mybatis-test 🟥 failed 1, success 0, total 1 11 min New failing
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 1, success 5, total 6 43 min Existing failure
idc-jenkins-ci/integration-cdc-test ✅ all 39 tests passed 18 min Fixed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 11 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 7 min 6 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 23 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 3 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 14 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@bb7133 bb7133 bb7133 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support extension stmt events API
5 participants
@lcwangchao @ti-chi-bot @sre-bot @bb7133 @xhebox