Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix outer join's bad change to inner join depend on wrong null-reject check logic #38698

Closed
wants to merge 2 commits into from

Conversation

AilinKid
Copy link
Contributor

@AilinKid AilinKid commented Oct 27, 2022

Signed-off-by: AilinKid [email protected]

What problem does this PR solve?

Issue Number: close #38654

Problem Summary:

What is changed and how it works?

// case: null AND 1 we should keep the null value's continuity, the final result can be determinant as null.
// case: null OR 0 we should keep the null value's continuity, the final result can be determinant as null.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix outer join's bad change to inner join depend on wrong null-reject check logic

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 27, 2022
Signed-off-by: AilinKid <[email protected]>
@hawkingrei hawkingrei requested a review from Yisaer October 27, 2022 16:06
@Yisaer
Copy link
Contributor

Yisaer commented Oct 28, 2022

duplicated fix in #38702

@AilinKid
Copy link
Contributor Author

#38702 do have some old code refactor, use that

@AilinKid AilinKid closed this Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected Results by RIGHT JOIN
3 participants