Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extension: add more informations to extension context #38693

Merged
merged 5 commits into from
Oct 27, 2022
Merged

extension: add more informations to extension context #38693

merged 5 commits into from
Oct 27, 2022

Conversation

lcwangchao
Copy link
Collaborator

@lcwangchao lcwangchao commented Oct 27, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #38493

What is changed and how it works?

add more informations to extension context

Check List

Tests

  • No code

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 27, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 27, 2022
@lcwangchao lcwangchao mentioned this pull request Oct 27, 2022
Open
14 tasks
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 27, 2022
@hawkingrei
Copy link
Member

/run-build

1 similar comment
@hawkingrei
Copy link
Member

/run-build

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 27, 2022
@hawkingrei
Copy link
Member

/run-build

1 similar comment
@hawkingrei
Copy link
Member

/run-build

@wuhuizuo
Copy link
Contributor

/run-build
/run-mysql-test

1 similar comment
@wuhuizuo
Copy link
Contributor

/run-build
/run-mysql-test

@wuhuizuo
Copy link
Contributor

/run-build

@wuhuizuo
Copy link
Contributor

/run-mysql-test

@lcwangchao
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b7cd57e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 27, 2022
@ti-chi-bot ti-chi-bot merged commit 18698d1 into pingcap:master Oct 27, 2022
@lcwangchao lcwangchao deleted the extension_add_context branch October 27, 2022 12:16
@sre-bot
Copy link
Contributor

sre-bot commented Oct 27, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [2] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test ✅ all 17 tests passed 12 min Fixed
idc-jenkins-ci-tidb/integration-compatibility-test ✅ all 1 tests passed 2 min 45 sec Fixed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 22 min Existing passed
idc-jenkins-ci/integration-cdc-test 🟢 all 38 tests passed 21 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 9 min 24 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 44 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 5 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 5 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 2 min 56 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lcwangchao @ti-chi-bot @hawkingrei @wuhuizuo @sre-bot @xhebox