Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json: add json_storage_free function #38544

Merged
merged 4 commits into from
Oct 21, 2022

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Oct 19, 2022

Signed-off-by: YangKeao [email protected]

What problem does this PR solve?

Issue Number: close #38517

Problem Summary:

Implement json_storage_free function

What is changed and how it works?

As TiDB doesn't support in place json partial update, json_storage_free function is implemented with simply return an zero for any valid json value.

  1. If it's NULL, return NULL
  2. If it's an invalid json, return error
  3. Else, return 0.

Related tipb updates: pingcap/tipb#274

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Add `json_storage_free` function to keep compatible with MySQL

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 19, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • xhebox
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 19, 2022
@YangKeao YangKeao requested review from xiongjiwei and xhebox October 20, 2022 07:15
@YangKeao
Copy link
Member Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 21, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 21, 2022
"//planner/core",
"//testkit",
"//types",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some extra changes, because someone forgot to update the bazel rules (through make bazel_prepare). I have checked with @hawkingrei and I could submit these diffs with this PR.

@YangKeao
Copy link
Member Author

/run-unit-test

@YangKeao
Copy link
Member Author

@xiongjiwei @xhebox Could you help me to merge this PR?

@xhebox
Copy link
Contributor

xhebox commented Oct 21, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e6b896b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 21, 2022
@ti-chi-bot ti-chi-bot merged commit 873a3ea into pingcap:master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement JSON_STORAGE_FREE function
4 participants