-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
json: add json_storage_free function #38544
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
1715a95
to
d51d435
Compare
/run-all-tests |
Signed-off-by: YangKeao <[email protected]>
23db917
to
10992ec
Compare
"//planner/core", | ||
"//testkit", | ||
"//types", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some extra changes, because someone forgot to update the bazel rules (through make bazel_prepare
). I have checked with @hawkingrei and I could submit these diffs with this PR.
Signed-off-by: YangKeao <[email protected]>
2b7e9d5
to
6f18e13
Compare
/run-unit-test |
Signed-off-by: YangKeao <[email protected]>
@xiongjiwei @xhebox Could you help me to merge this PR? |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: e6b896b
|
Signed-off-by: YangKeao [email protected]
What problem does this PR solve?
Issue Number: close #38517
Problem Summary:
Implement
json_storage_free
functionWhat is changed and how it works?
As TiDB doesn't support in place json partial update,
json_storage_free
function is implemented with simply return an zero for any valid json value.Related tipb updates: pingcap/tipb#274
Check List
Tests
Documentation
Release note