Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Table partition double write during Reorganize partition (part 2) #38508

Merged
merged 10 commits into from
Dec 30, 2022
Merged

*: Table partition double write during Reorganize partition (part 2) #38508

merged 10 commits into from
Dec 30, 2022

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Oct 17, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #15000 , ref #38535

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@mjonss mjonss requested a review from a team as a code owner October 17, 2022 13:06
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 17, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 17, 2022
@mjonss
Copy link
Contributor Author

mjonss commented Oct 19, 2022

/run-all-test

@mjonss
Copy link
Contributor Author

mjonss commented Oct 19, 2022

/run-all-tests

@mjonss mjonss mentioned this pull request Oct 30, 2022
Closed
13 tasks
@mjonss mjonss mentioned this pull request Nov 16, 2022
Merged
12 tasks
@mjonss
Copy link
Contributor Author

mjonss commented Dec 5, 2022

/run-unit-test

@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 23, 2022
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 23, 2022
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 23, 2022
@mjonss
Copy link
Contributor Author

mjonss commented Dec 23, 2022

/run-check_dev_2

bb7133
bb7133 approved these changes Dec 29, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 29, 2022
@mjonss
Copy link
Contributor Author

mjonss commented Dec 30, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4702033

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 30, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Dec 30, 2022
@mjonss mjonss changed the title *: Table partition double write during Reorganize partition (part 2) *: Table partition double write during Reorganize partition (part 2) | tidb-test=pr/2044 Dec 30, 2022
@mjonss
Copy link
Contributor Author

mjonss commented Dec 30, 2022

/retest

@mjonss
Copy link
Contributor Author

mjonss commented Dec 30, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e0308d7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 30, 2022
@mjonss
Copy link
Contributor Author

mjonss commented Dec 30, 2022

/retest

@ti-chi-bot ti-chi-bot merged commit b259112 into pingcap:feature/reorganize-partition Dec 30, 2022
@mjonss mjonss changed the title *: Table partition double write during Reorganize partition (part 2) | tidb-test=pr/2044 *: Table partition double write during Reorganize partition (part 2) Jan 16, 2023
This was referenced Jan 31, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@bb7133 bb7133 bb7133 approved these changes

@tangenta tangenta Awaiting requested review from tangenta

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjonss @ti-chi-bot @bb7133 @tiancaiamao