Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: add foreign key cascade delete when execute delete statement #38377

Merged
merged 35 commits into from
Oct 21, 2022
Merged

*: add foreign key cascade delete when execute delete statement #38377

merged 35 commits into from
Oct 21, 2022

Conversation

crazycs520
Copy link
Contributor

Signed-off-by: crazycs520 [email protected]

What problem does this PR solve?

Issue Number: close #38376

Problem Summary: add foreign key cascade delete when execute delete statement

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@crazycs520 crazycs520 added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 10, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 10, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ekexium
  • you06

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 10, 2022
@crazycs520 crazycs520 added sig/planner SIG: Planner sig/execution SIG execution type/new-feature and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 10, 2022
@wuhuizuo
Copy link
Contributor

/run-all-tests

@crazycs520
refine code
27135af 
Signed-off-by: crazycs520 <[email protected]>
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 11, 2022
@crazycs520
fix lint
7c0627b 
Signed-off-by: crazycs520 <[email protected]>
@crazycs520
refine code
262ff1b 
Signed-off-by: crazycs520 <[email protected]>
@crazycs520
fix lint
26465dc 
Signed-off-by: crazycs520 <[email protected]>
@crazycs520
Merge branch 'master' of https://github.com/pingcap/tidb into fk-casc…
fbea9d2 
…ade-delete
@crazycs520
refine
de8d42d 
Signed-off-by: crazycs520 <[email protected]>
@crazycs520
Copy link
Contributor Author

/run-mysql-test

@crazycs520
Copy link
Contributor Author

/run-all-tests

@wuhuizuo
Copy link
Contributor

/run-build

@crazycs520
add more test case
261180e 
Signed-off-by: crazycs520 <[email protected]>
cfzjywxk
cfzjywxk reviewed Oct 18, 2022
View reviewed changes
executor/adapter.go Outdated Show resolved Hide resolved
executor/adapter.go Outdated
Comment on lines 626 to 637
e, err := fkc.buildExecutor(ctx)
if err != nil || e == nil {
return err
}
if err := e.Open(ctx); err != nil {
terror.Call(e.Close)
return err
}
_, _, e, err = a.handleNoDelay(ctx, e, isPessimistic)
if err != nil {
return err
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite clear about the previous state assumptions, maybe it's better to add some descriptions to explain the safety, which states of a statement execution may change or may not change.
For example, should the executions refresh the for_update_ts or they should always use the same one?

Copy link
Contributor Author

@crazycs520 crazycs520 Oct 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, maybe I shouldn't reuse handleNoDelay here, write an handleFKExecutor method to handle it maybe better.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have refactored the logic here, PTAL

executor/foreign_key.go Outdated
if err != nil {
return nil, err
}
err = ResetContextOfStmt(sctx, stmtNode)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ResetContextOfStmt is called by the execution framework. The function uildFKCascadePlan does something the same as the framework does, maybe it's better to reuse the existing functions by making necessary changes to them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It really doesn't quite fit here, so it has been deleted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have refactored the logic here, PTAL

@crazycs520
Copy link
Contributor Author

It seems explain analyze doesn't work with cascade delete, e.g. explain analyze delete from the parent table doesn't delete the referencing row in the child table.

It seems explain analyze doesn't work with cascade delete, e.g. explain analyze delete from the parent table doesn't delete the referencing row in the child table.

Nice catch, since the PR already too large, I create an issue #38513 for it and fix it in another PR.

I mean it doesn't do the cascade delete in an explain analyze, not only missing information in returned results.

It's fixed now.

@crazycs520
Copy link
Contributor Author

/run-all-tests

you06
you06 reviewed Oct 20, 2022
View reviewed changes
executor/foreign_key.go Outdated Show resolved Hide resolved
executor/adapter.go Outdated Show resolved Hide resolved
@crazycs520
address comment
67bb65f 
Signed-off-by: crazycs520 <[email protected]>
@crazycs520
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a5ca023

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 21, 2022
@crazycs520
Copy link
Contributor Author

/build

@hawkingrei
Copy link
Member

/run-build

@ti-chi-bot ti-chi-bot merged commit 4346898 into pingcap:master Oct 21, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Oct 21, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟥 failed 1, success 16, total 17 15 min New failing
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 1, success 5, total 6 30 min Existing failure
idc-jenkins-ci/integration-cdc-test 🔴 failed 1, success 37, total 38 21 min Existing failure
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 9 min 22 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 7 min 14 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 41 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 30 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 12 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 1 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@crazycs520 crazycs520 deleted the fk-cascade-delete branch October 21, 2022 09:44
@crazycs520 crazycs520 mentioned this pull request Oct 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfzjywxk cfzjywxk cfzjywxk left review comments

@ekexium ekexium ekexium approved these changes

@you06 you06 you06 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. sig/execution SIG execution sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support foreign key cascade delete
8 participants
@crazycs520 @ti-chi-bot @wuhuizuo @ekexium @hawkingrei @sre-bot @cfzjywxk @you06