Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

txn: add table name in dup entry error message #38243

Merged
merged 10 commits into from
Oct 19, 2022
Merged

txn: add table name in dup entry error message #38243

merged 10 commits into from
Oct 19, 2022

Conversation

ekexium
Copy link
Contributor

@ekexium ekexium commented Sep 29, 2022 •
edited
Loading

Signed-off-by: ekexium [email protected]

What problem does this PR solve?

Issue Number: close #38242

Problem Summary:

Print table name in error 1042: duplicate entry with the column/index name

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Improve the error message of 1042: duplicate entry, which makes it different from the error message in MySQL.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 29, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TonsnakeLin
  • sticnarf

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/invalid-title release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 29, 2022
@ekexium ekexium changed the title add table name in dup entry error message txn: add table name in dup entry error message Sep 29, 2022
@TonsnakeLin
Copy link
Contributor

We should add a test case for unique-index I think.

@ekexium
fix: for index
3b88e32 
Signed-off-by: ekexium <[email protected]>
@ekexium
Copy link
Contributor Author

ekexium commented Sep 30, 2022 •
edited
Loading

We should add a test case for unique-index I think.

Good catch! I missed it.

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 17, 2022
@ekexium
test: fix unit tests
89f1d72 
Signed-off-by: ekexium <[email protected]>
@ekexium ekexium force-pushed the dup-error-table-name branch from c0ddff4 to 89f1d72 Compare October 17, 2022 14:28
@ekexium
Copy link
Contributor Author

ekexium commented Oct 17, 2022

/run-mysql-test tidb-test=pr/1995

2 similar comments
@ekexium
Copy link
Contributor Author

ekexium commented Oct 17, 2022

/run-mysql-test tidb-test=pr/1995

@ekexium
Copy link
Contributor Author

ekexium commented Oct 17, 2022

/run-mysql-test tidb-test=pr/1995

@ekexium
Copy link
Contributor Author

ekexium commented Oct 17, 2022

/run-mysql-test tidb-test=pr/1995

@ekexium
Copy link
Contributor Author

ekexium commented Oct 17, 2022

/run-mysql-test tidb-test=pr/1995
/run-check_dev_2
/run-build

@ekexium
Copy link
Contributor Author

ekexium commented Oct 17, 2022

/run-check_dev_2

@ekexium
Copy link
Contributor Author

ekexium commented Oct 18, 2022

/run-mysql-test tidb-test=pr/1995

4 similar comments
@ekexium
Copy link
Contributor Author

ekexium commented Oct 18, 2022

/run-mysql-test tidb-test=pr/1995

@ekexium
Copy link
Contributor Author

ekexium commented Oct 18, 2022

/run-mysql-test tidb-test=pr/1995

@ekexium
Copy link
Contributor Author

ekexium commented Oct 18, 2022

/run-mysql-test tidb-test=pr/1995

@ekexium
Copy link
Contributor Author

ekexium commented Oct 18, 2022

/run-mysql-test tidb-test=pr/1995

@ekexium
Copy link
Contributor Author

ekexium commented Oct 18, 2022

/run-mysql-test tidb-test=pr/1995

@ekexium
Copy link
Contributor Author

ekexium commented Oct 18, 2022

/run-check_dev_2
/run-build

@ekexium
Copy link
Contributor Author

ekexium commented Oct 18, 2022

/run-check_dev_2

@ekexium
Copy link
Contributor Author

ekexium commented Oct 18, 2022

@TonsnakeLin @sticnarf Could you help take a look at this and the corresponding mysql-PR? We're gonna merge them together.

@sticnarf
Copy link
Contributor

LGTM but the CI seems unhappy...

sticnarf
sticnarf approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@sticnarf sticnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 18, 2022
@ekexium
Copy link
Contributor Author

ekexium commented Oct 18, 2022

/run-mysql-test tidb-test=pr/1995

@ekexium
Copy link
Contributor Author

ekexium commented Oct 18, 2022

/run-mysql-test tidb-test=pr/1995

TonsnakeLin
TonsnakeLin approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@TonsnakeLin TonsnakeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No missing point of setting table name for ErrKeyExists is found. LGTM.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 19, 2022
@ekexium
Copy link
Contributor Author

ekexium commented Oct 19, 2022

/run-mysql-test tidb-test=pr/1995

@ekexium
Copy link
Contributor Author

ekexium commented Oct 19, 2022

/run-unit-test

@sticnarf
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f8c8500

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 19, 2022
@sticnarf sticnarf merged commit 9743a9a into pingcap:master Oct 19, 2022
@purelind purelind mentioned this pull request Oct 21, 2022
Merged
@ekexium ekexium mentioned this pull request Nov 2, 2022
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei left review comments

@TonsnakeLin TonsnakeLin TonsnakeLin approved these changes

@sticnarf sticnarf sticnarf approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include table name in the error message of 1062: duplicate entry
5 participants
@ekexium @ti-chi-bot @TonsnakeLin @sticnarf @hawkingrei