Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: reopen CTE in apply only when correlate #38214

Merged
merged 7 commits into from
Sep 29, 2022
Merged

planner: reopen CTE in apply only when correlate #38214

merged 7 commits into from
Sep 29, 2022

Conversation

wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Sep 28, 2022 •
edited
Loading

Signed-off-by: wjhuang2016 [email protected]

What problem does this PR solve?

Issue Number: close #38170

Problem Summary:
Previously, we reopened every CTE on the inner side of apply.
Consider the follow plan:

HashJoin
--APPLY(build)
---- CTE0
--CTE0(probe)

The CTE in APPLY would reopen, then the CTE on the probe side of the HashJoin will read the incomplete result.

What is changed and how it works?

reopen CTE in apply only when correlate

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix a bug causes wrong result when CTE is used in apply and join.

@wjhuang2016
done
e378fc2 
Signed-off-by: wjhuang2016 <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 28, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • guo-shaoge
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-6.3 and removed release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed labels Sep 28, 2022
@wuhuizuo
Copy link
Contributor

/run-check-dev

@wjhuang2016
add test
5449c34 
Signed-off-by: wjhuang2016 <[email protected]>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 28, 2022
@wjhuang2016
refine comment
6d95e2a 
Signed-off-by: wjhuang2016 <[email protected]>
@guo-shaoge guo-shaoge self-requested a review September 28, 2022 06:43
@wuhuizuo
Copy link
Contributor

/run-check-dev

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 28, 2022
@wuhuizuo
Copy link
Contributor

/run-check-dev

@wuhuizuo
Copy link
Contributor

/run-check-dev2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 29, 2022
@guo-shaoge
Copy link
Collaborator

/run-mysql-test

@hawkingrei
Copy link
Member

/run-check_dev_2

@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9533c58

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 29, 2022
@hawkingrei
Copy link
Member

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit df5f05f into pingcap:master Sep 29, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: cannot checkout 5.3: error checking out 5.3: exit status 1. output: error: pathspec '5.3' did not match any file(s) known to git

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: cannot checkout 5.4: error checking out 5.4: exit status 1. output: error: pathspec '5.4' did not match any file(s) known to git

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: cannot checkout 6.1: error checking out 6.1: exit status 1. output: error: pathspec '6.1' did not match any file(s) known to git

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: cannot checkout 6.3: error checking out 6.3: exit status 1. output: error: pathspec '6.3' did not match any file(s) known to git

@sre-bot
Copy link
Contributor

sre-bot commented Sep 29, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [2] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🟥 failed 1, success 5, total 6 25 min New failing
idc-jenkins-ci-tidb/integration-common-test 🟥 failed 1, success 16, total 17 12 min New failing
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 9 min 23 sec Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 37 tests passed 27 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 47 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 3 min 53 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 58 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 2 min 58 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

morgo added a commit to morgo/tidb that referenced this pull request Oct 4, 2022
@morgo
Merge remote-tracking branch 'upstream/master' into sessionctx-code-i…
06bcee9 
…mprovements

* upstream/master: (56 commits)
  expression: make a copy when retrieving json path expression from cache (pingcap#38285)
  executor: make unit test TestIssue21732 stable (pingcap#38278)
  variables: enable variable hook to access storage (pingcap#38227)
  docs: update roadmap description (pingcap#38253)
  systable: Adapt with TiFlash system table update (pingcap#38191)
  planner, util/ranger: restrict mem usage for index join inner ranges (pingcap#38129)
  planner: separate cost model ver1/ver2 into different files (part 2) (pingcap#38273)
  metrics: Add IOPs, Disk Throughput to the overview dashboard (pingcap#38270)
  planner: refine index join range display for clustered index (pingcap#38259)
  *: delete `mInFlashbackCluster` related codes (pingcap#38241)
  session: turn the transaction to pessimistic mode when retrying (pingcap#38130)
  executor: enable race for executor/aggfuncs (pingcap#38262)
  planner: reopen CTE in apply only when correlate (pingcap#38214)
  planner: enable revive (pingcap#36649)
  *: add foreign key constraint check when execute update statement (pingcap#38156)
  *: DATA RACE in the temptable.AttachLocalTemporaryTableInfoSchema (pingcap#38237)
  executor,sessionctx: enable coprocessor paging and make TestCoprocessorPagingSize stable (pingcap#38161)
  domain: fix data race in the Domain.bindHandle (pingcap#38223)
  test: add information if test failed (pingcap#38234)
  preprocessor, planner: inline processing by default for single-consumer cte (pingcap#37800)
  ...
@wjhuang2016 wjhuang2016 deleted the fix_apply_cte branch November 17, 2022 11:07
@guo-shaoge
Copy link
Collaborator

/run-cherry-picker

@winoros
Copy link
Member

winoros commented May 15, 2023

/run-cherry-picker release-6.1

winoros pushed a commit to winoros/tidb that referenced this pull request May 15, 2023
@wjhuang2016 @winoros
planner: reopen CTE in apply only when correlate (pingcap#38214)
3d21630 
close pingcap#38170
@winoros winoros mentioned this pull request May 15, 2023
Merged
12 tasks
@winoros
Copy link
Member

winoros commented Jun 29, 2023

/run-cherry-picker release-6.1

winoros pushed a commit to winoros/tidb that referenced this pull request Jun 29, 2023
@wjhuang2016 @winoros
planner: reopen CTE in apply only when correlate (pingcap#38214)
b7ca406 
close pingcap#38170
@winoros winoros mentioned this pull request Jun 29, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jun 30, 2023
@winoros
planner: reopen CTE in apply only when correlate (#38214) (#45066)
54a8c45 
ref #38214
@guo-shaoge guo-shaoge mentioned this pull request Oct 10, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@time-and-fate time-and-fate time-and-fate approved these changes

@guo-shaoge guo-shaoge guo-shaoge approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undetermined results of the SELECT statement with CTE
9 participants
@wjhuang2016 @ti-chi-bot @wuhuizuo @guo-shaoge @hawkingrei @sre-bot @winoros @time-and-fate @AilinKid