Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor,sessionctx: enable coprocessor paging and make TestCoprocessorPagingSize stable #38161

Merged
merged 7 commits into from
Sep 29, 2022
Merged

executor,sessionctx: enable coprocessor paging and make TestCoprocessorPagingSize stable #38161

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e49c2d9
executor,sessionctx: enable coprocessor paging and make TestCoprocess…
tiancaiamao Sep 26, 2022
3534642
Merge branch 'master' into enable-paging
tiancaiamao Sep 26, 2022
964c1c0
Merge branch 'master' into enable-paging
hawkingrei Sep 26, 2022
e8e9db3
Merge branch 'master' into enable-paging
hawkingrei Sep 26, 2022
ebf1d79
address comment
tiancaiamao Sep 27, 2022
6abeb7e
Merge branch 'master' into enable-paging
tiancaiamao Sep 27, 2022
1b0226b
Merge branch 'master' into enable-paging
ti-chi-bot Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions executor/distsql_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,9 @@ func TestCoprocessorPagingSize(t *testing.T) {
tk.MustExec(fmt.Sprintf("insert into t_paging values %v", strings.Join(values, ", ")))
tk.MustQuery("select @@tidb_min_paging_size").Check(testkit.Rows(strconv.FormatUint(paging.MinPagingSize, 10)))

// Enable the coprocessor paging protocol.
tk.MustExec("set @@tidb_enable_paging = on")

// When the min paging size is small, we need more RPC roundtrip!
// Check 'rpc_num' in the execution information
//
Expand Down
2 changes: 1 addition & 1 deletion sessionctx/variable/tidb_vars.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1051,7 +1051,7 @@ const (
DefTiDBPrepPlanCacheMemoryGuardRatio = 0.1
DefTiDBEnableConcurrentDDL = concurrencyddl.TiDBEnableConcurrentDDL
DefTiDBSimplifiedMetrics = false
DefTiDBEnablePaging = false
DefTiDBEnablePaging = true
DefTiFlashFineGrainedShuffleStreamCount = 0
DefStreamCountWhenMaxThreadsNotSet = 8
DefTiFlashFineGrainedShuffleBatchSize = 8192
Expand Down