Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sessionctx: set tidb_enable_paging to false #37920

Merged
merged 3 commits into from
Sep 19, 2022
Merged

sessionctx: set tidb_enable_paging to false #37920

merged 3 commits into from
Sep 19, 2022

Conversation

XuHuaiyu
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #37919

Problem Summary:

What is changed and how it works?

Check List

Tests

Using the current test cases.

Side effects

N/A

Documentation

N/A

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@XuHuaiyu XuHuaiyu added the type/enhancement The issue or PR belongs to an enhancement. label Sep 19, 2022
@XuHuaiyu XuHuaiyu requested a review from a team as a code owner September 19, 2022 03:24
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 19, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 19, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 19, 2022
@hawkingrei hawkingrei requested review from qw4990, a team and bb7133 September 19, 2022 03:28
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 19, 2022
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 72b7727

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 19, 2022
@ti-chi-bot ti-chi-bot merged commit d1c532f into pingcap:master Sep 19, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Sep 19, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 52 min Existing failure
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 1, success 5, total 6 23 min Existing failure
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 2, success 15, total 17 9 min 12 sec Existing failure
idc-jenkins-ci/integration-cdc-test ✅ all 37 tests passed 30 min Fixed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 0 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 44 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 3 min 52 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 25 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 51 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@bb7133
Copy link
Member

bb7133 commented Sep 19, 2022

Theoretically this PR closes #37768.

This was referenced Sep 26, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

@bb7133 bb7133 Awaiting requested review from bb7133

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tidb_enable_paging should set to false for branch release-6.3
7 participants
@XuHuaiyu @ti-chi-bot @hawkingrei @sre-bot @bb7133 @qw4990 @wshwsh12