Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: support plan replayer dump explain file #37807

Merged
merged 8 commits into from
Sep 15, 2022
Merged

parser: support plan replayer dump explain file #37807

merged 8 commits into from
Sep 15, 2022

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Sep 14, 2022

Signed-off-by: yisaer [email protected]

What problem does this PR solve?

Issue Number: ref #37798

Problem Summary:

What is changed and how it works?

Support plan replayer dump explain file

Check List

Tests

  • Unit test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Yisaer
support parser
cd6ea81 
Signed-off-by: yisaer <[email protected]>
@Yisaer
add test
2e8389b 
Signed-off-by: yisaer <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 14, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • xuyifangreeneyes

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 14, 2022
xuyifangreeneyes
xuyifangreeneyes reviewed Sep 14, 2022
View reviewed changes
Copy link
Contributor

@xuyifangreeneyes xuyifangreeneyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one question that may be not very related to the pr: if there are some sqls which cannot be explained, do we return error or just skip them? Currently it seems to return syntax error. Rest LGTM.

parser/parser.y
Stmt: nil,
Analyze: true,
Load: false,
File: $6,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In PLAN REPLAYER LOAD 'dump_file', we set PlanReplayerStmt.File to dump_file. Maybe we can add comment to explain different usages of PlanReplayerStmt.File between PLAN REPLAYER DUMP and PLAN REPLAYER LOAD or we can use different fields for different usages.

Copy link
Contributor Author

@Yisaer Yisaer Sep 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comment now.

@hawkingrei
Copy link
Member

/run-unit-test

@Yisaer
Copy link
Contributor Author

Yisaer commented Sep 14, 2022

I have one question that may be not very related to the pr: if there are some sqls which cannot be explained, do we return error or just skip them? Currently it seems to return syntax error. Rest LGTM.

Currently we will return error now.

@Yisaer
Copy link
Contributor Author

Yisaer commented Sep 14, 2022

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2022
@Yisaer
Copy link
Contributor Author

Yisaer commented Sep 14, 2022

/hold cancel

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2022
@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 14, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 15, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 15, 2022
@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8af4525

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 15, 2022
@ti-chi-bot ti-chi-bot merged commit 26f4604 into pingcap:master Sep 15, 2022
@Yisaer Yisaer deleted the support_replayer_workload branch September 15, 2022 03:55
@sre-bot
Copy link
Contributor

sre-bot commented Sep 15, 2022

TiDB MergeCI notify

🔴 Bad News! [3] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 34 min Existing failure
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 1, success 5, total 6 24 min Existing failure
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 2, success 15, total 17 9 min 3 sec Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 37 tests passed 24 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 16 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 4 min 50 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 3 min 55 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 7 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 46 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuyifangreeneyes xuyifangreeneyes xuyifangreeneyes approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Yisaer @ti-chi-bot @hawkingrei @sre-bot @xuyifangreeneyes