Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser, execution: support kill connection_id() #37650

Merged
merged 5 commits into from
Oct 21, 2022
Merged

parser, execution: support kill connection_id() #37650

merged 5 commits into from
Oct 21, 2022

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Sep 6, 2022 •
edited
Loading

Signed-off-by: Weizhen Wang [email protected]

What problem does this PR solve?

Issue Number: close #37261

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
kill connection_id()

// success to kill.
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

parser, execution: support kill connection_id()

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 6, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tangenta
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 6, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 7, 2022
@hawkingrei hawkingrei force-pushed the support_kill_tidb_connection_id branch from 81937a7 to a2e5e55 Compare October 14, 2022 09:14
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 14, 2022
@hawkingrei hawkingrei changed the title WIP parser: support kill connection_id() parser, execution: support kill connection_id() Oct 14, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2022
@hawkingrei
Copy link
Member Author

/run-unit-test

@hawkingrei hawkingrei force-pushed the support_kill_tidb_connection_id branch 2 times, most recently from cde91f5 to 0e239fd Compare October 16, 2022 13:19
tangenta
tangenta reviewed Oct 17, 2022
View reviewed changes
parser/ast/misc.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 19, 2022
@hawkingrei hawkingrei force-pushed the support_kill_tidb_connection_id branch from b953ddd to 26f39ad Compare October 19, 2022 09:27
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 19, 2022
@hawkingrei hawkingrei force-pushed the support_kill_tidb_connection_id branch from 26f39ad to 5dafa66 Compare October 20, 2022 06:35
xhebox
xhebox reviewed Oct 21, 2022
View reviewed changes
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete parser.go.commited

@hawkingrei
update
8c89c0c 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
parser: support kill connection_id()
0595299 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
*: refactor error
389904b 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei hawkingrei force-pushed the support_kill_tidb_connection_id branch from 5dafa66 to 389904b Compare October 21, 2022 04:32
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 21, 2022
@hawkingrei
Copy link
Member Author

/run-build
/run-unit-test

@hawkingrei
Copy link
Member Author

@xiongjiwei @tangenta PTAL

tangenta
tangenta reviewed Oct 21, 2022
View reviewed changes
executor/simple.go Outdated Show resolved Hide resolved
@hawkingrei
update
299be57 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 21, 2022
@tangenta
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 299be57

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 21, 2022
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 21, 2022
@hawkingrei
Copy link
Member Author

/run-build

@ti-chi-bot ti-chi-bot merged commit 9d606cd into pingcap:master Oct 21, 2022
@hawkingrei hawkingrei deleted the support_kill_tidb_connection_id branch October 21, 2022 08:05
@sre-bot
Copy link
Contributor

sre-bot commented Oct 21, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [2] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test ✅ all 6 tests passed 24 min Fixed
idc-jenkins-ci/integration-cdc-test ✅ all 38 tests passed 23 min Fixed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 11 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 8 min 45 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 12 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 53 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 24 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 32 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 1 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngaut ngaut ngaut left review comments

@tangenta tangenta tangenta approved these changes

@xhebox xhebox xhebox approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

@xiongjiwei xiongjiwei Awaiting requested review from xiongjiwei

@Icemap Icemap Awaiting requested review from Icemap

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support KILL TIDB connection_id()
6 participants
@hawkingrei @ti-chi-bot @tangenta @sre-bot @ngaut @xhebox