Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression, executor, plan: rewrite builtin function substring_index. #3760

Merged

Conversation

SteveZhangBit
Copy link
Contributor

No description provided.

@XuHuaiyu XuHuaiyu added the contribution This PR is from a community contributor. label Jul 14, 2017
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SteveZhangBit SteveZhangBit force-pushed the SteveZhangBit/builtin-substrindex branch from 6bd8d1e to 04619ff Compare July 15, 2017 09:23
@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 16, 2017
@XuHuaiyu
Copy link
Contributor

LGTM, please resolve the conflicts.

@XuHuaiyu XuHuaiyu added conflicting status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 17, 2017
@hanfei1991 hanfei1991 merged commit 8805688 into pingcap:master Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants