executor: a naive support for load data fields enclosed by #3759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @zimulala |
|
PTAL @hanfei1991 |
shenli
reviewed
Jul 20, 2017
executor/write.go
Outdated
| if c, ok = escapeChar(str[i+1]); ok { | ||
| i++ | ||
| } | ||
| c, _ = escapeChar(str[i+1]) |
There was a problem hiding this comment.
Why ignore ok？ Any test case covers this?
shenli
reviewed
Jul 20, 2017
| if c, ok = escapeChar(str[i+1]); ok { | ||
| i++ | ||
| } | ||
| c = escapeChar(str[i+1]) |
There was a problem hiding this comment.
What will the result be if we meet "\c"?
There was a problem hiding this comment.
\c is escaped to c
|
LGTM |
shenli
approved these changes
Jul 20, 2017
shenli
added
status/LGT2
|
Please update the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very naive way to support fields enclosed by xxx:
change
split(input, terminated)to
split(input, enclosed+terminated+enclosed)@zimulala @shenli