executor, util: fix UnionScan Next() skip reading data when passed chunk capacity is 0 (#36961) #37335
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #36961 to release-6.2
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/37335
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #36903
Problem Summary:
What is changed and how it works?
In the old UnionScan executor code, if an empty chk is passed to
UnionScan.Next(chk)
, the UnionScan executor will not read any data.This bug could be trigger in
select pkey from t_vwvgdc where 0 <> 0 union select pkey from t_vwvgdc;
The union first children return empty chunk, and the chunk is reused for the second children (union scan) to read data.
Now I change
req.GrowAndReset(us.maxChunkSize)
to ensure capacity > 0 for thereq
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.