-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor, util: fix UnionScan Next() skip reading data when passed chunk capacity is 0 (#36961) #37330
Conversation
Signed-off-by: ti-srebot <[email protected]>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@tiancaiamao you're already a collaborator in bot's repo. |
This pull request is closed because it's related version has closed automatic cherry-picking. You can find more details at: |
cherry-pick #36961 to release-5.2
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/37330
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #36903
Problem Summary:
What is changed and how it works?
In the old UnionScan executor code, if an empty chk is passed to
UnionScan.Next(chk)
, the UnionScan executor will not read any data.This bug could be trigger in
select pkey from t_vwvgdc where 0 <> 0 union select pkey from t_vwvgdc;
The union first children return empty chunk, and the chunk is reused for the second children (union scan) to read data.
Now I change
req.GrowAndReset(us.maxChunkSize)
to ensure capacity > 0 for thereq
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.