-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: implement comparison between json opaque #37316
Conversation
Signed-off-by: YangKeao <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
but please triage your issue in TiRelease, or just skip the triage of this PR.
/run-check-issue-triage-complete |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 0f4c693
|
/run-mysql-test tidb-test=pr/1937 |
/run-mysql-test |
/run-mysql-test tidb-test=pr/1937 |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/0f4c69355d9b8c11708d96d8a0e00450ef238730 |
TiDB MergeCI notify🔴 Bad News! [2] CI still failing after this pr merged.
|
Signed-off-by: YangKeao [email protected]
What problem does this PR solve?
Issue Number: close #37315
Problem Summary:
The comparison between json opaque is not implemented. They are currently comparing the
.GetString
of them, which will cause panic!What is changed and how it works?
Implement the json opaque through comparing the
.GetOpaque().Buf
.Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.