Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: make auto-analyze concurrency configurable #37078

Merged
merged 15 commits into from
Nov 30, 2022
Merged

*: make auto-analyze concurrency configurable #37078

merged 15 commits into from
Nov 30, 2022

Conversation

chrysan
Copy link
Contributor

@chrysan chrysan commented Aug 12, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #37183

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 12, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • xuyifangreeneyes

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 12, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 12, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 12, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/ede49bb546c92bd9d995e7daa3bb2947e1a2ce27

@chrysan chrysan changed the title executor: do not limit auto-analyze concurrency too aggressively *: make auto-analyze concurrency configurable Aug 22, 2022
@chrysan chrysan requested a review from a team as a code owner August 26, 2022 07:10
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 26, 2022
jackysp
jackysp reviewed Aug 26, 2022
View reviewed changes
executor/adapter.go Outdated Show resolved Hide resolved
@winoros winoros mentioned this pull request Aug 28, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this pull request Aug 29, 2022
@winoros
*: make auto-analyze concurrency configurable & push part of order pr…
7de48a2 
…op to partition table (#37421)

ref #36108, ref #37078
@xuyifangreeneyes
Copy link
Contributor

/run-e2e-test

1 similar comment
@xuyifangreeneyes
Copy link
Contributor

/run-e2e-test

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2022
winoros added a commit to winoros/tidb that referenced this pull request Oct 28, 2022
@winoros
cherry pick pingcap#37078
10e6c4e
@winoros winoros mentioned this pull request Oct 28, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 30, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 30, 2022
@qw4990
Copy link
Contributor

qw4990 commented Nov 30, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: fec40dd

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2022
@xuyifangreeneyes
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0c8c0e9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2022
@xuyifangreeneyes
Copy link
Contributor

/run-build

@xuyifangreeneyes
Copy link
Contributor

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit 8e4748a into pingcap:master Nov 30, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Nov 30, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [2] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟥 failed 2, success 15, total 17 28 min New failing
idc-jenkins-ci-tidb/integration-ddl-test 🟥 failed 1, success 5, total 6 6 min 57 sec New failing
idc-jenkins-ci-tidb/sqllogic-test-1 ✅ all 26 tests passed 7 min 28 sec Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 40 tests passed 25 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 6 min 30 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 16 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 42 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 9 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@xuyifangreeneyes xuyifangreeneyes xuyifangreeneyes approved these changes

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

auto-analyze is slow due to hardcoded concurrency 1
7 participants
@chrysan @ti-chi-bot @sre-bot @xuyifangreeneyes @qw4990 @jackysp @hawkingrei