Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: introduce new functions for the general statement in session interface #37024

Merged
merged 13 commits into from
Aug 11, 2022
Merged

planner: introduce new functions for the general statement in session interface #37024

merged 13 commits into from
Aug 11, 2022

Conversation

Reminiscent
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #36598

Problem Summary:
Introduce new functions for the general statement in session interface for general plan cache.

What is changed and how it works?

  1. Add the ExecuteGeneralStmt function for general statement as the frontend in plan cache.
  2. Add executePlanCacheStmt to unify the prepare statement and general statement.
  3. Add GeneralStmts map[string]interface{} in SessionVars to store the planCacheStmt for general statement.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Reminiscent Reminiscent requested a review from qw4990 August 10, 2022 09:15
@Reminiscent Reminiscent requested a review from a team as a code owner August 10, 2022 09:15
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 10, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Yisaer
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 10, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 10, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/a1eda241a324d6343b78271f2d4faadef8d2da12

@qw4990
Copy link
Contributor

qw4990 commented Aug 11, 2022

Please resolve conflicts @Reminiscent

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 11, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 11, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 11, 2022
@qw4990 qw4990 requested a review from Yisaer August 11, 2022 06:51
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 11, 2022
@qw4990
Copy link
Contributor

qw4990 commented Aug 11, 2022

/run-unit-test

@qw4990
Copy link
Contributor

qw4990 commented Aug 11, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a1eda24

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 11, 2022
@ti-chi-bot ti-chi-bot merged commit 25b63df into pingcap:master Aug 11, 2022
@Reminiscent Reminiscent deleted the refactor-ExecutrPreparedStmtByQuery branch August 11, 2022 08:22
morgo added a commit to morgo/tidb that referenced this pull request Aug 11, 2022
@morgo
Merge remote-tracking branch 'upstream/master' into improve-sysvar-co…
d71b97f 
…verage

* upstream/master: (98 commits)
  planner: provide a unified interface to set and get user variables and types (pingcap#37046)
  *: fix check-2 to bazel (pingcap#37055)
  distsql: revert 37019 (pingcap#37048)
  planner: introduce new functions for the general statement in session interface (pingcap#37024)
  session: make BenchmarkCompileExecutePreparedStmt update to date (pingcap#36960)
  server: Change proxyprotocol to lazy mode (pingcap#36301)
  test: fix `TestDDLSchedulingMultiTimes` and `TestConcurrentDDLSwitch` timeout (pingcap#37043)
  makefile: add bazel realtikvtest (pingcap#37042)
  distsql: make analyze request SI (pingcap#37019)
  *: gofmt code for adapting go 1.19 (pingcap#36832)
  planner: fix data race in the TestInlineProjection4HashJoinIssue15316 (pingcap#37014)
  planner: introduce Session.CacheGeneralStmt for general plan cache (pingcap#37028)
  server: revise scheme code (pingcap#37021)
  planner: fix unstable test TestPushDownSelectionForMPP (pingcap#37038)
  executor: more precise memory tracking (pingcap#35785)
  executor: add privilege check for prepare stmt (pingcap#36933)
  *: optimize temptable.SessionSnapshotInterceptor (pingcap#36999)
  statistics: batch insert topn and buckets to storage to speed up loading stats (pingcap#36948)
  planner: remove keyword `prepared` in plan cache backend (pingcap#37023)
  util: fix unstable test TestCheckCN (pingcap#37016)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yisaer Yisaer Yisaer approved these changes

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
epic/plan-cache release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Reminiscent @ti-chi-bot @sre-bot @qw4990 @Yisaer