Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: introduce hashRowContainer.GetMatchedRows method (#36848) #36864

Merged
merged 2 commits into from
Aug 4, 2022
Merged

executor: introduce hashRowContainer.GetMatchedRows method (#36848) #36864

merged 2 commits into from
Aug 4, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Aug 3, 2022 •
edited
Loading

cherry-pick #36848 to release-6.2
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/36864

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/36864:release-6.2-3a74656a5a4a

What problem does this PR solve?

Issue Number: close #36847

Problem Summary:

What is changed and how it works?

Introduce the hashRowContainer.GetMatchedRows method since we do not need the Ptr info in HashJoinExec.joinMatchedProbeSideRow2Chunk

Check List

Tests

Before this commit:
TPCDS Q95 costs 126s

After this commit:
TPCDS Q95 costs 113s
飞书20220803-171505

Side effects

  • N/A

Documentation

  • N/A

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 3, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • guo-shaoge
  • zanmato1984

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 3, 2022
@ti-srebot ti-srebot mentioned this pull request Aug 3, 2022
Merged
@ti-srebot ti-srebot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/6.2-cherry-pick type/enhancement The issue or PR belongs to an enhancement. labels Aug 3, 2022
@ti-srebot
Copy link
Contributor Author

@XuHuaiyu you're already a collaborator in bot's repo.

zanmato1984
zanmato1984 approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 3, 2022
@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 3, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 3, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 3, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/f80f881b72be7bc0a3deeaefca33a8e89a5bc98b

@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Aug 4, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e5b5b0e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 4, 2022
@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Aug 4, 2022

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 9e909bf into pingcap:release-6.2 Aug 4, 2022
@hawkingrei hawkingrei deleted the release-6.2-3a74656a5a4a branch August 4, 2022 03:18
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guo-shaoge guo-shaoge guo-shaoge approved these changes

@zanmato1984 zanmato1984 zanmato1984 approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees

@XuHuaiyu XuHuaiyu

Labels
do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement. type/6.2-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ti-srebot @ti-chi-bot @sre-bot @XuHuaiyu @zanmato1984 @guo-shaoge @VelocityLight