-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: add a http interface to change labels #36845
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/b4b78bca1ffcdc5a48b934828edc3363c5032ded |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 2bbe07c
|
TiDB MergeCI notify🔴 Bad News! [1] CI still failing after this pr merged.
|
@glorv why doesn't this PR include release notes? |
Sorry. I originally thought this is a tiny change that needn't be included in the release note. |
What problem does this PR solve?
Issue Number: ref #35926
Problem Summary:
What is changed and how it works?
This PR add a new interface under the status port to update tidb's labels config. tidb-operator depends on this interface to set some labels (e.g. zone) to the tidb server after the server is started. This is the same way as tidb-operator set tikv's labels to PD.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.