Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: also collect unchanged unique keys for lock #36498

Merged
merged 11 commits into from
Jul 25, 2022
Merged

executor: also collect unchanged unique keys for lock #36498

merged 11 commits into from
Jul 25, 2022

Conversation

zyguan
Copy link
Contributor

@zyguan zyguan commented Jul 24, 2022

Signed-off-by: zyguan [email protected]

What problem does this PR solve?

Issue Number: close #36438

Problem Summary: Only row keys will be locked after update nothing, which leads to #36438.

What is changed and how it works?

Also collect unchanged unique keys and lock them.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@zyguan zyguan requested review from cfzjywxk and jackysp July 24, 2022 09:12
@zyguan zyguan requested a review from a team as a code owner July 24, 2022 09:12
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 24, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • jackysp
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 24, 2022
@zyguan
fixup
f65ec97 
Signed-off-by: zyguan <[email protected]>
@sre-bot
Copy link
Contributor

sre-bot commented Jul 24, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/6ec5feccb88348c8fab7ed4cef6bffd41eeeed2b

jackysp
jackysp approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 25, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 25, 2022
@tangenta
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f65ec97

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 25, 2022
@hawkingrei
Copy link
Member

/check-issue-triage-complete

@tangenta
Copy link
Contributor

/hold Waiting for the approval from @pingcap/tidb-configuration-reviewer

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2022
@cfzjywxk cfzjywxk removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2022
@cfzjywxk
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@zyguan: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hawkingrei
Copy link
Member

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit c80026e into pingcap:master Jul 25, 2022
@zyguan zyguan mentioned this pull request Aug 9, 2022
Closed
zyguan added a commit to zyguan/tidb that referenced this pull request Aug 10, 2022
@zyguan
executor: revert pingcap#36498 to avoid perf regression
0be5140 
Signed-off-by: zyguan <[email protected]>
@zyguan zyguan mentioned this pull request Aug 10, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this pull request Aug 10, 2022
@zyguan
executor: revert #36498 to avoid perf regression (#37005)
45f82af 
ref #36438
MyonKeminta added a commit to MyonKeminta/tidb that referenced this pull request Aug 15, 2022
@MyonKeminta
Revert "executor: also collect unchanged unique keys for lock (pingca…
da6c7d4 
…p#36498)"

This reverts commit c80026e.
@zyguan zyguan mentioned this pull request Mar 30, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp approved these changes

@tangenta tangenta tangenta approved these changes

@cfzjywxk cfzjywxk cfzjywxk approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unique key lock not consistent when row is changed or not
7 participants
@zyguan @ti-chi-bot @sre-bot @tangenta @hawkingrei @cfzjywxk @jackysp