-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log-backup: calculate global checkpoint-ts from storage #36255
Conversation
Signed-off-by: joccau <[email protected]>
Signed-off-by: joccau <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/fe1d80e2496c04ce2b5b8ccc2c111632b1ed3c0b |
@@ -1264,7 +1265,7 @@ func getLogRange( | |||
logMinTS := mathutil.Max(logStartTS, truncateTS) | |||
|
|||
// get max global resolved ts from metas. | |||
logMaxTS, err := getGlobalResolvedTS(ctx, s) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function getGlobalResolvedTS
seems to be no longer used.
Signed-off-by: joccau <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 310afe4
|
TiDB MergeCI notify🔴 Bad News! New failing [2] after this pr merged.
|
What problem does this PR solve?
Issue Number: close #36246
Problem Summary:
What is changed and how it works?
tikv
periodically.Check List
Tests
manual test
● Total 1 Tasks.
[2022/07/17 19:37:38.659 +08:00] [INFO] [collector.go:69] ["log metadata"] [log-min-ts=434582449885806593] [log-min-date="2022-07-14 20:08:03.268 +0800 CST"] [log-max-ts=434649900624904193] [log-max-date="2022-07-17 19:36:27.418 +0800 CST"]
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.