*: make SET TRANSACTION ISOLATION LEVEL READ COMMITTED take effect #3619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiancaiamao
force-pushed
the
tiancaiamao/read-committed
branch
from
c4c2ae6 to
f4ed935
Compare
shenli
reviewed
Jul 4, 2017
| tp.Charset, tp.Collate = parser.charset, parser.collation | ||
| expr := ast.NewValueExpr($3) | ||
| expr.SetType(tp) | ||
| $$ = &ast.VariableAssignment{Name: "tx_isolation", Value: expr, IsSystem: true} |
There was a problem hiding this comment.
tx_isolation is a session variable name.
I don't want to put it in other places except variable package.
I also don't like parser package to import variable package.
So use the string "tx_isolation" is the best compromise.
session.go
Outdated
| @@ -1130,6 +1130,9 @@ func (s *session) ActivePendingTxn() error { | |||
| if err != nil { | |||
| return errors.Trace(err) | |||
| } | |||
| if s.sessionVars.Systems[variable.TxnIsolation] == "READ-COMMITTED" { | |||
|
Any need to print error when user wants to set unsupported levels? |
it is equivalent to setting "tx_isolation" variable. if the value is READ-COMMITTED, set the transaction isolation level option.
tiancaiamao
force-pushed
the
tiancaiamao/read-committed
branch
from
f4ed935 to
e38a2fc
Compare
|
Need to set |
|
|
LGTM |
|
LGTM |
shenli
approved these changes
Jul 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is equivalent to setting "tx_isolation" variable.
if the value is READ-COMMITTED, set the transaction isolation level option.
@disksing @zimulala @shenli