-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: enable unconvert #35821
Merged
Merged
*: enable unconvert #35821
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e73dd3e
*: enable unconvert
hawkingrei 205d67f
*: enable unconvert
hawkingrei e71a3c4
*: enable unconvert
hawkingrei 472da15
*: enable unconvert
hawkingrei e43a93a
*: enable unconvert
hawkingrei 8f09e24
Merge branch 'master' into unconvert
ti-chi-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| load("@io_bazel_rules_go//go:def.bzl", "go_library") | ||
|
|
||
| go_library( | ||
| name = "unconvert", | ||
| srcs = ["analysis.go"], | ||
| importpath = "github.com/pingcap/tidb/build/linter/unconvert", | ||
| visibility = ["//visibility:public"], | ||
| deps = [ | ||
| "//build/linter/util", | ||
| "@com_github_golangci_unconvert//:unconvert", | ||
| "@org_golang_x_tools//go/analysis", | ||
| "@org_golang_x_tools//go/loader", | ||
| ], | ||
| ) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| // Copyright 2022 PingCAP, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package unconvert | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "go/token" | ||
| "go/types" | ||
|
|
||
| unconvertAPI "github.com/golangci/unconvert" | ||
| "github.com/pingcap/tidb/build/linter/util" | ||
| "golang.org/x/tools/go/analysis" | ||
| "golang.org/x/tools/go/loader" | ||
| ) | ||
|
|
||
| // Name is the name of the analyzer. | ||
| const Name = "unconvert" | ||
|
|
||
| // Analyzer is the analyzer struct of unconvert. | ||
| var Analyzer = &analysis.Analyzer{ | ||
| Name: Name, | ||
| Doc: "Remove unnecessary type conversions", | ||
| Run: run, | ||
| } | ||
|
|
||
| func run(pass *analysis.Pass) (interface{}, error) { | ||
| var createdPkgs []*loader.PackageInfo | ||
| createdPkgs = append(createdPkgs, util.MakeFakeLoaderPackageInfo(pass)) | ||
| allPkgs := map[*types.Package]*loader.PackageInfo{} | ||
| for _, pkg := range createdPkgs { | ||
| pkg := pkg | ||
| allPkgs[pkg.Pkg] = pkg | ||
| } | ||
| prog := &loader.Program{ | ||
| Fset: pass.Fset, | ||
| Imported: nil, // not used without .Created in any linter | ||
| Created: createdPkgs, // all initial packages | ||
| AllPackages: allPkgs, // all initial packages and their depndencies | ||
| } | ||
| positions := unconvertAPI.Run(prog) | ||
| if len(positions) == 0 { | ||
| return nil, nil | ||
| } | ||
|
|
||
| for _, pos := range positions { | ||
| pass.Reportf(token.Pos(pos.Offset), fmt.Sprintf("[%s] Unnecessary conversion", Name)) | ||
| } | ||
| return nil, nil | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Later you should add a method document or file document about all these analyzers' semantic. For example, what case is good and what case is bad. It's not intuitive for developer reading the code and understand the effective rule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a good suggestion. I have a plan to write a document to add a new linter into TiDB repo by the nogo after complete golangci-linter mrigate. I should write the document as soon as possible. I find much new linter can be added in the TiDB.