-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix index_lookup_hash_join hang when used with limit #35820
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: guo-shaoge <[email protected]>
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/2e5a10135e416c624ebee84f01433155f13573f6 |
Signed-off-by: guo-shaoge <[email protected]>
@@ -608,7 +608,10 @@ func (iw *indexHashJoinInnerWorker) handleTask(ctx context.Context, task *indexH | |||
if task.keepOuterOrder { | |||
if err != nil { | |||
joinResult.err = err | |||
resultCh <- joinResult | |||
select { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add mysql test as case: https://github.com/pingcap/tidb-test/pull/1887
/run-all-tests |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.0 in PR #36098 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.1 in PR #36099 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.2 in PR #36100 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.3 in PR #36101 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.4 in PR #36102 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-6.0 in PR #36103 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-6.1 in PR #36104 |
TiDB MergeCI notify✅ Well Done! New fixed [1] after this pr merged.
|
Signed-off-by: guo-shaoge [email protected]
What problem does this PR solve?
Issue Number: close #35638
Problem Summary:
IndexLookupHashJoin hangs when used with limit.
innerWorker of IndexLookupHashJoin is still running when limitExec calls Close(). So no goroutine will read result, which makes the
task.resultCh
be full, and it's stucked when innerWorker try to push result.What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.