Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BR: fix backup ranges total time summary log #35552

Merged
merged 4 commits into from
Jun 23, 2022
Merged

BR: fix backup ranges total time summary log #35552

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1bfe247
BR: fix backup ranges total time summary log
ixuh12 Jun 20, 2022
12444c5
Merge branch 'master' into master
hawkingrei Jun 21, 2022
5f7ec82
Merge branch 'pingcap:master' into master
ixuh12 Jun 23, 2022
efd6e53
Merge branch 'master' into master
ti-chi-bot Jun 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion br/pkg/backup/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,9 @@ func (bc *Client) BackupRanges(
progressCallBack func(ProgressUnit),
) error {
init := time.Now()
defer log.Info("Backup Ranges", zap.Duration("take", time.Since(init)))
defer func() {
log.Info("Backup Ranges", zap.Duration("take", time.Since(init)))
joccau marked this conversation as resolved.
Show resolved Hide resolved
}()

if span := opentracing.SpanFromContext(ctx); span != nil && span.Tracer() != nil {
span1 := span.Tracer().StartSpan("Client.BackupRanges", opentracing.ChildOf(span.Context()))
Expand Down