-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DNM]Using bazel as building tool #3539
Conversation
493578e
to
df028d2
Compare
@shenli bazel build //tidb-server/... |
b81a35b
to
5ac15c3
Compare
PR is ready to review. What do I propose in this PR?
What is the benefit of these proposals?
I recommnad we maintain two build system until all developers are familar with
|
@zhexuany OK I will take a look. |
There is one workaround in this PR. |
change
to
could be better? |
as a templet of every go package make it easy when some add a file to a go package, he do not need to mod the build file, while preserve the sematics |
No need actually. All And for your last suggestion, your solution is great and I already adopt your suggestion. But do you know any way to cached test result? Review status: 0 of 864 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
just run |
|
@zhexuany We will consider this latter. |
This change is