Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: close RecordSet #35341

Merged
merged 2 commits into from
Jun 14, 2022
Merged

*: close RecordSet #35341

merged 2 commits into from
Jun 14, 2022

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jun 13, 2022 •
edited
Loading

Signed-off-by: Weizhen Wang [email protected]

What problem does this PR solve?

Issue Number: ref #31716

Problem Summary:

What is changed and how it works?

In history, We have met many problems caused by forgetting to close RecordSet. so we refactor the test case by closing the record set to make the test stable.

Check List

Tests

  • Unit test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@hawkingrei
*: close RecordSet
e7413c1 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 13, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ngaut
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 13, 2022
@hawkingrei hawkingrei mentioned this pull request Jun 13, 2022
Merged
4 tasks
@sre-bot
Copy link
Contributor

sre-bot commented Jun 13, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/1ce9c3b701140d537048e1c92886eb1650a44bf5

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 13, 2022
@hawkingrei
clean code
1ce9c3b 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/needs-linked-issue labels Jun 13, 2022
@hawkingrei hawkingrei requested a review from tisonkun June 13, 2022 16:21
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 13, 2022
tisonkun
tisonkun reviewed Jun 14, 2022
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems related to cleanup code to use testkit methods. What's the relation to close RecordSet?

@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1ce9c3b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 14, 2022
@hawkingrei
Copy link
Member Author

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2022
@hawkingrei
Copy link
Member Author

This change seems related to cleanup code to use testkit methods. What's the relation to close RecordSet?

In history, We have met many problems caused by forgetting to close RecordSet. so we refactor the test case by closing the record set to make the test stable.

tisonkun
tisonkun approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right that ExecToErr closes the RecordSet while Exec doesn't.

@tisonkun
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2022
@ti-chi-bot ti-chi-bot merged commit b0b1c7c into pingcap:master Jun 14, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 14, 2022

TiDB MergeCI notify

🔴 Bad News! [1] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 2, success 9, total 11 19 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 35 tests passed 28 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 30 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 19 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 9 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 42 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 1 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 51 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@hawkingrei hawkingrei mentioned this pull request Dec 20, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiongjiwei xiongjiwei xiongjiwei approved these changes

@tisonkun tisonkun tisonkun approved these changes

@ngaut ngaut ngaut approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hawkingrei @ti-chi-bot @sre-bot @tisonkun @ngaut @xiongjiwei