-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: support paging protocol on unistore #35244
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9a03a0c
*: support paging protocol on unistore
tiancaiamao a17a85e
find a dynamic partition mode bug
tiancaiamao 7fc9f67
fix issue 35242
tiancaiamao 43df086
clean debug log
tiancaiamao 4921240
reset the paging default value to disabled
tiancaiamao 2291f31
make golint happy
tiancaiamao 712780f
Merge branch 'master' into paging-unistore
tiancaiamao b2221dc
Merge branch 'master' into paging-unistore
tiancaiamao c9229e0
Merge branch 'master' into paging-unistore
tiancaiamao 68f94d1
Merge branch 'master' into paging-unistore
hawkingrei eae342b
Merge branch 'master' into paging-unistore
tiancaiamao 827ef7b
Merge branch 'master' into paging-unistore
ti-chi-bot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that
ReqTypeAnalyze
will not use paging. We do not need toset enable_paging = false
for the analyze tests.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
paging is a property of the kv request,
kv request can be one of the following kinds:
As you can see, there are
ReqTypeDAG
andReqTypeAnalyze
, and alsoReqTypeChecksum
foradmin check table
... for now, we just supportReqTypeDAG
, so all other casesreq.Paging = false
is set.A possible change is that we can move the
paging
property tocoprocessor.Request
.That change would make it clear that
paging
is a property ofReqTypeDAG
(orcoprocessor.Request
to be more specific), not a propertykv.Request
.The drawback of the change is, if one day, we need paging protocol also for
Analyze/Checksum
, we need to add the property tokv.Request
...