Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add ci image #35212

Closed
wants to merge 5 commits into from
Closed

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jun 7, 2022

Signed-off-by: Weizhen Wang [email protected]

What problem does this PR solve?

Issue Number: ref #31716

Problem Summary:

What is changed and how it works?

  • add Jenkins dockerfile
  • fix the bazel config in the br and update makefile

Q: Why do we need to add CI Dockerfile to TiDB repo?
A: I want to give developers more abilities to control CI. so we just update the Dockerfile( environment) and makefile (logic) to change the CI and they can debug the CI problem or update in the local machine.

Check List

Tests

  • Unit test
  • Integration test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 7, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 7, 2022
@hawkingrei
Copy link
Member Author

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Jun 7, 2022

@hawkingrei hawkingrei changed the title *: add ci image *: add ci image and update bazel config Jun 8, 2022
@hawkingrei hawkingrei force-pushed the add_jenkins_dockerfile branch from 6a2df32 to f3521a3 Compare June 8, 2022 03:55
Copy link
Contributor

@WizardXiao WizardXiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM about lightning's change, but here maybe needs other dev take a look about the image's change.

@hawkingrei
Copy link
Member Author

LGTM about lightning's change, but here maybe needs other dev take a look about the image's change.

OK

Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I can not really build the docker file since it is internal.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2022
@hawkingrei hawkingrei force-pushed the add_jenkins_dockerfile branch from 924cc5a to 70a507f Compare June 10, 2022 10:03
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 10, 2022
@hawkingrei hawkingrei changed the title *: add ci image and update bazel config *: add ci image Jun 21, 2022
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei hawkingrei force-pushed the add_jenkins_dockerfile branch from a60fd8a to e2ae7c8 Compare June 21, 2022 08:32
Signed-off-by: Weizhen Wang <[email protected]>
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some comments to describe that this is used internally.

@tisonkun tisonkun removed their request for review August 26, 2022 10:10
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 18, 2022
@hawkingrei hawkingrei closed this Feb 3, 2023
@hawkingrei hawkingrei deleted the add_jenkins_dockerfile branch February 3, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants