-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: add ci image #35212
*: add ci image #35212
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-unit-test |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/6ad56c38659989411ad9e7421ee7e927e2b646ae |
6a2df32
to
f3521a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM about lightning's change, but here maybe needs other dev take a look about the image's change.
OK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I can not really build the docker file since it is internal.
924cc5a
to
70a507f
Compare
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
a60fd8a
to
e2ae7c8
Compare
Signed-off-by: Weizhen Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some comments to describe that this is used internally.
Signed-off-by: Weizhen Wang [email protected]
What problem does this PR solve?
Issue Number: ref #31716
Problem Summary:
What is changed and how it works?
Q: Why do we need to add CI Dockerfile to TiDB repo?
A: I want to give developers more abilities to control CI. so we just update the Dockerfile( environment) and makefile (logic) to change the CI and they can debug the CI problem or update in the local machine.
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.