expression: wrap arguments when new built-in function #3520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanfei1991
reviewed
Jun 21, 2017
expression/builtin.go
Outdated
| return baseBuiltinFunc{ | ||
| args: args, | ||
| argValues: make([]types.Datum, len(args)), | ||
| ctx: ctx, | ||
| deterministic: true, | ||
| tp: tp, | ||
| } | ||
| tp: retType}, errors.Trace(err) |
There was a problem hiding this comment.
At this line, err must be nil
|
PTAL @hanfei1991 |
|
LGTM |
|
PTAL @shenli |
zimulala
reviewed
Jun 21, 2017
expression/builtin.go
Outdated
| // thus the `tp` attribute is needed for `baseBuiltinFunc` | ||
| // to obtain the FieldType of a ScalarFunction. | ||
| func newBaseBuiltinFuncWithTp(args []Expression, tp *types.FieldType, ctx context.Context) baseBuiltinFunc { | ||
| // newBaseBuiltinFuncWithTp create a built-in function signature with specified types of arguments and return type. |
There was a problem hiding this comment.
s/create/creates
s/return type/ returns a type
expression/builtin.go
Outdated
| // Every built-in function needs determined argTps and retType when we create it. | ||
| func newBaseBuiltinFuncWithTp(args []Expression, retType *types.FieldType, ctx context.Context, argTps ...argTp) (bf baseBuiltinFunc, err error) { | ||
| if len(args) != len(argTps) { | ||
| panic("unexpected length of args and argTps") |
There was a problem hiding this comment.
len(args) must equals to len(argTps),
and argTps is set by the coder,
so here I use panic to give warning.
| args[i], err = WrapWithCastAsTime(args[i], types.NewFieldType(mysql.TypeDatetime), ctx) | ||
| case tpDuration: | ||
| args[i], err = WrapWithCastAsDuration(args[i], ctx) | ||
| } |
There was a problem hiding this comment.
The err value will be covered.
expression/expression.go
Outdated
| // but what we actually get is store as float64 in Datum. | ||
| // So if we wrap `CastDecimalAsInt` upon the result, we'll get <nil> when call `arg.EvalDecimal()`. | ||
| // This will be fixed after all built-in functions be rewrite correctlly. | ||
| // return val.GetMysqlDecimal(), false, nil |
| case *builtinValuesSig: | ||
| switch sf.FuncName.L { | ||
| case ast.Cast: | ||
| newFunc, _ := buildCastFunction(sf.GetArgs()[0], sf.GetType(), sf.GetCtx()) |
There was a problem hiding this comment.
This is a Clone func of ScalarFunction,
the error will never happen.
|
PTAL @zimulala |
zimulala
reviewed
Jun 21, 2017
| @@ -171,7 +171,7 @@ func (s *testEvaluatorSuite) TestConcat(c *C) { | |||
| } | |||
| fc := funcs[fcName].(*concatFunctionClass) | |||
| for _, t := range typeCases { | |||
| retType := fc.inferType(t.args) | |||
| retType, _ := fc.inferType(t.args) | |||
| @@ -249,7 +253,7 @@ func (b *castAsStringFunctionClass) getFunction(args []Expression, ctx context.C | |||
| sig = &builtinCastStringAsStringSig{bf} | |||
| } | |||
| } | |||
| return sig, errors.Trace(b.verifyArgs(args)) | |||
| return sig.setSelf(sig), errors.Trace(b.verifyArgs(args)) | |||
There was a problem hiding this comment.
Why do we need to set self-value？
If we really need to do that，line 237 also need to be set.
|
LGTM |
zimulala
approved these changes
Jun 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of every arguments and return type should be determined
when building built-in function signatures,
before this commit, we wrap cast in
runtimewhich is not efficient,this commit wrap cast for args when getFunction.
PTAL @hanfei1991 @shenli