-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: make output field name in show tables/databases stmt
compatible with mysql
#35136
Merged
Merged
Changes from 7 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
60b8709
compatible show tables/databases stmt with mysql
likzn 8454e21
fix test
likzn ce18ca5
fix test
likzn e5e99c1
clean code
likzn 17c644d
Merge branch 'master' into fix_show_field
hawkingrei 2f060fa
fix test
likzn c07b523
Merge remote-tracking branch 'origin/fix_show_field' into fix_show_field
likzn b2283c1
Update planner/core/planbuilder.go
likzn 9778fcf
add extra flag to determine to buildPattern or not
likzn af33c19
Merge branch 'master' into fix_show_field
likzn 1a25e10
refactor
likzn 4ce665e
Merge remote-tracking branch 'origin/fix_show_field' into fix_show_field
likzn dbbb054
Merge branch 'master' into fix_show_field
ti-chi-bot a76c382
Merge branch 'master' into fix_show_field
ti-chi-bot d00da11
Merge branch 'master' into fix_show_field
ti-chi-bot 0d68569
Merge branch 'master' into fix_show_field
ti-chi-bot 90e1aae
Merge branch 'master' into fix_show_field
ti-chi-bot 639586b
Merge branch 'master' into fix_show_field
ti-chi-bot 9e9a371
Merge branch 'master' into fix_show_field
tangenta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
show tables like '%xx'; | ||
Tables_in_test (%xx) | ||
show databases like '%xx'; | ||
Database (%xx) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# test show output field name | ||
show tables like '%xx'; | ||
show databases like '%xx'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain why removing
show.Pattern = nil
a little bit?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is introduced in #31919 to fix
case insentive
with some show statment. It mean if we havenewShowBaseExtractor
, we will not buildshow.Pattern
in line 3015. But in this case, we need extractpatternLikeName
inshow.Pattern
. So i remove it and add an extra check in line 3015 to make them behave same.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is safer to mark an extra flag like
noShowPattern
or somethine similar. There are some other extractors that may be introduced later.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. An extra flag is more clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to add it to
LogicalShow
struct, a variable inbuildShow
is enough 🤣There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, yes. Just finished exercise, my head is a little dizzy