-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util: optimize the memory usage of the read path for listInDisk #34778
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/efa178aa521463c29cd6036b5b09e3029aca0076 |
util/chunk/disk.go
Outdated
@@ -39,6 +39,8 @@ type ListInDisk struct { | |||
|
|||
dataFile diskFileReaderWriter | |||
offsetFile diskFileReaderWriter | |||
|
|||
chk *Chunk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment for this attribute.
chk := &Chunk{columns: make([]*Column, 0, len(format.sizesOfColumns))} | ||
// toRow deserializes diskFormatRow to Row. | ||
func (format *diskFormatRow) toRow(fields []*types.FieldType, chk *Chunk) (Row, *Chunk) { | ||
if chk == nil || chk.IsFull() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quesction, chk == nil
maybe unnecessary? Because sync.Pool will always new a chunk.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check chk==nil
is more safe.. For example, the code in test cases doesn't have the sync.Pool and doesn't need to reuse.
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 821f656
|
@wshwsh12: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: ref #33877
close #35631
Problem Summary:
Optimize the memory usage of the read path for list in disk.
What is changed and how it works?
Check List
Tests
Workload: A big table with 5kw lines 1, a small table with 1 lines 1.
SQL: desc analyze select * from small_table where exists (select a from v5kw big_table where small_table.b=big_table.b);
Plan: With memory quota 1GB
Before this pr: TiDB use 60GB+ and OOM.
After this pr: We can see the GC line is 5.6GB, so the memory usage after each GC is 2.8GB
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.