Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: remove stats cache unnecessary lock and revise log #34726

Merged
merged 6 commits into from
May 17, 2022
Merged

statistics: remove stats cache unnecessary lock and revise log #34726

merged 6 commits into from
May 17, 2022

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented May 17, 2022 •
edited
Loading

Signed-off-by: yisaer [email protected]

What problem does this PR solve?

Issue Number: ref #34052

Problem Summary:

What is changed and how it works?

  1. revise stats cache lru log and update capacity log won't be appeared every 30 seconds.
  2. remove stats cache unnecessary lock

Check List

Tests

  • Manual test (add detailed scripts or steps below)
  • run tidb-server and see no more update stats cache capacity succssfully logs cyclely.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Yisaer added 2 commits May 17, 2022 12:03
@Yisaer
revise log
aead383 
Signed-off-by: yisaer <[email protected]>
@Yisaer
revise log
7db05dd 
Signed-off-by: yisaer <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 17, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • xuyifangreeneyes

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 17, 2022
@Yisaer Yisaer requested a review from xuyifangreeneyes May 17, 2022 04:10
@sre-bot
Copy link
Contributor

sre-bot commented May 17, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/cd2345d7df29c2417d130301c69fd93ddce4b490

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 17, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 17, 2022
@Yisaer
Copy link
Contributor Author

Yisaer commented May 17, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7db05dd

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 17, 2022
@hawkingrei
Copy link
Member

/run-mysql-test

1 similar comment
@hawkingrei
Copy link
Member

/run-mysql-test

@Yisaer
remove lock
972f4e0 
Signed-off-by: yisaer <[email protected]>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed status/can-merge Indicates a PR has been approved by a committer. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 17, 2022
@Yisaer Yisaer changed the title statistics: revise stats cache lru log statistics: remove stats cache unnecessary lock and revise log May 17, 2022
@Yisaer
address the comment
2b5d886 
Signed-off-by: yisaer <[email protected]>
@Yisaer
Copy link
Contributor Author

Yisaer commented May 17, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: cd2345d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 17, 2022
@Yisaer
Copy link
Contributor Author

Yisaer commented May 17, 2022

/run-mysql-test

@Yisaer Yisaer merged commit 586716b into pingcap:master May 17, 2022
@Yisaer Yisaer deleted the revise_log branch May 17, 2022 12:58
@sre-bot
Copy link
Contributor

sre-bot commented May 17, 2022

TiDB MergeCI notify

🔴 Bad News! [1] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 4, success 7, total 11 8 min 51 sec Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 34 tests passed 23 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 8 min 30 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 8 min 0 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 7 min 48 sec Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 5 min 36 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 4 min 59 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 4 min 38 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 32 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@XuHuaiyu XuHuaiyu mentioned this pull request May 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuyifangreeneyes xuyifangreeneyes xuyifangreeneyes approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@JmPotato JmPotato JmPotato approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Yisaer @ti-chi-bot @sre-bot @hawkingrei @JmPotato @xuyifangreeneyes