Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: add loading region cache duration #34679

Merged
merged 8 commits into from
Jun 29, 2022
Merged

metrics: add loading region cache duration #34679

merged 8 commits into from
Jun 29, 2022

Conversation

you06
Copy link
Contributor

@you06 you06 commented May 16, 2022 •
edited
Loading

Signed-off-by: you06 [email protected]

What problem does this PR solve?

Issue Number: ref #34106

Problem Summary:

tikv/client-go#502 collects the duration of loading region cache and this PR add it to the dashboard.

What is changed and how it works?

image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Add loading region cache duration metrics.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 16, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • sticnarf

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 16, 2022
@you06
Copy link
Contributor Author

you06 commented May 16, 2022

/run-monitor-test

@sre-bot
Copy link
Contributor

sre-bot commented May 16, 2022

Visit the grafana server at: http://172.16.5.5:31869, it will last for 5 hours

@sre-bot
Copy link
Contributor

sre-bot commented May 16, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/d4931ecbc7cb8a1c3a4e622d3c6eb5651fb32c91

@you06 you06 force-pushed the region-cache-duration branch from 31fa8c6 to 29ee485 Compare May 18, 2022 03:15
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-linked-issue labels May 18, 2022
@you06
add latency for loading region region
c056e85 
Signed-off-by: you06 <[email protected]>

add load region ok panel

Signed-off-by: you06 <[email protected]>

update client-go

Signed-off-by: you06 <[email protected]>

update client-go

Signed-off-by: you06 <[email protected]>
@you06 you06 force-pushed the region-cache-duration branch from 29ee485 to c056e85 Compare June 13, 2022 08:40
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2022
@you06
add avg duration
e4dc22a 
Signed-off-by: you06 <[email protected]>
@you06 you06 requested review from sticnarf and cfzjywxk June 13, 2022 09:18
@you06
change id
d1fb724 
Signed-off-by: you06 <[email protected]>
@sticnarf
Copy link
Contributor

I'm not sure if these panels should be put in the "Meta" row. To my understanding "meta" refers to some internal data used by TiDB while region cache is not.

The "KV Request" row may be more appropriate?

cfzjywxk
cfzjywxk reviewed Jun 13, 2022
View reviewed changes
metrics/grafana/tidb.json Outdated Show resolved Hide resolved
@you06
Copy link
Contributor Author

you06 commented Jun 14, 2022

I'm not sure if these panels should be put in the "Meta" row.

Because "Region Cache Error OPS" panel is put in "Meta" now, so I just put the related panels together.

The "KV Request" row may be more appropriate?

Agree, will move all region cache panels into "KV Request" row.

@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 14, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 28, 2022
@cfzjywxk
Copy link
Contributor

@sticnarf
PTAL

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 28, 2022
@sticnarf
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1d67b1a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 28, 2022
@sticnarf
Copy link
Contributor

/run_check_dev_2

@sticnarf
Copy link
Contributor

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit c5ad449 into pingcap:master Jun 29, 2022
morgo added a commit to morgo/tidb that referenced this pull request Jun 29, 2022
@morgo
Merge remote-tracking branch 'upstream/master' into remove-hidden-sys…
a104dff 
…vars

* upstream/master: (28 commits)
  *: enable unconvert (pingcap#35821)
  log-backup: check timezone when using datatime format ts string (pingcap#35811)
  planner: support the leading hint for outer join (pingcap#35264)
  lightning: revert new policy of allocating rowid and refine it later (pingcap#35817)
  txn: manage the initialization of RCCheckTS by transaction context provider (pingcap#35554)
  ddl: make output field name in `show tables/databases stmt` compatible with mysql (pingcap#35136)
  txn: remove `legacy.SimpleTxnContextProvider` (pingcap#35667)
  txn: fix the error message if retry could not be used for rc check ts (pingcap#35474)
  *: support canceling DDL statements with KILL (pingcap#35803)
  lightning: avoid extracting db schema when schema file is not provided (pingcap#35783)
  *: enable all gosimples (pingcap#35762)
  tools/check: skip 'tests' directory in 'make ut' (pingcap#35800)
  metrics: add loading region cache duration (pingcap#34679)
  ddl: DROP TABLE/VIEW/SEQUENCE now use XXXStmt as parameter (pingcap#35741)
  types: fix incompatible implementation of jsonpath extraction (pingcap#35320)
  planner: fix TRACE PLAN TARGET = 'estimation' panic when meeting partition table (pingcap#35743)
  *: Add `testfork.RunTest` to run multiple tests in one function (pingcap#35746)
  sessionctx/variable: add tests to ensure skipInit can be removed (pingcap#35703)
  helper: request another PD if one of them is unavailable (pingcap#35750)
  metrics: add cached table related metrics to grafana panel (pingcap#34718)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sticnarf sticnarf sticnarf approved these changes

@cfzjywxk cfzjywxk cfzjywxk approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@you06 @ti-chi-bot @sre-bot @sticnarf @cfzjywxk