Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: add unit test for assert tidb_stats_cache_mem_quota #34633

Merged
merged 7 commits into from
May 13, 2022
Merged

config: add unit test for assert tidb_stats_cache_mem_quota #34633

merged 7 commits into from
May 13, 2022

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented May 13, 2022

Signed-off-by: yisaer [email protected]

What problem does this PR solve?

Issue Number: ref #34052

Problem Summary:

add unit test for assert tidb_stats_cache_mem_quota

What is changed and how it works?

Check List

Tests

  • Unit test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Yisaer
add test
b1b432e 
Signed-off-by: yisaer <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 13, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • LittleFall
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 13, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 13, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 13, 2022
@Yisaer
Copy link
Contributor Author

Yisaer commented May 13, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b1b432e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 13, 2022
@sre-bot
Copy link
Contributor

sre-bot commented May 13, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/c05f4bf43a3d516525cd2aa1605b01fa6d209efa

1 similar comment
@sre-bot
Copy link
Contributor

sre-bot commented May 13, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/c05f4bf43a3d516525cd2aa1605b01fa6d209efa

@Yisaer
Copy link
Contributor Author

Yisaer commented May 13, 2022

/run-mysql-test

2 similar comments
@Yisaer
Copy link
Contributor Author

Yisaer commented May 13, 2022

/run-mysql-test

@Yisaer
Copy link
Contributor Author

Yisaer commented May 13, 2022

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit ad53ac2 into pingcap:master May 13, 2022
@sre-bot
Copy link
Contributor

sre-bot commented May 13, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟢 all 34 tests passed 24 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 7 min 43 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 42 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 25 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 22 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 13 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 4 min 26 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 2 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LittleFall LittleFall LittleFall approved these changes

@nolouch nolouch nolouch approved these changes

@xuyifangreeneyes xuyifangreeneyes Awaiting requested review from xuyifangreeneyes

@JmPotato JmPotato Awaiting requested review from JmPotato

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Yisaer @ti-chi-bot @sre-bot @nolouch @LittleFall