-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: plan cache always check scheme valid in RC isolation level (#34523) #34619
planner: plan cache always check scheme valid in RC isolation level (#34523) #34619
Conversation
Signed-off-by: ti-srebot <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@you06 you're already a collaborator in bot's repo. |
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/38cb240f4f2366d50745ec46b267b4a26f6003ae |
@lcwangchao @qw4990 PTAL. |
/run-mysql-test |
2 similar comments
/run-mysql-test |
/run-mysql-test |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 56a20db
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #34523 to release-5.4
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/34619
After apply modifications, you can push your change to this PR via:
Signed-off-by: you06 [email protected]
What problem does this PR solve?
Issue Number: close #34447
Problem Summary:
What is changed and how it works?
Plan cache always checks if the schema is stale in the RC isolation level because it should guarantee the index still exist in the latest schema.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.