session: return an error when a non-transactional DML partially fails

[ekexium]

Signed-off-by: ekexium [email protected]

What problem does this PR solve?

Issue Number: ref #33485

Problem Summary:

What is changed and how it works?

Previously we return a recordset containing errors when some jobs failed. That would misguide applications.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Add a system variable `tidb_nontransactional_ignore_error`

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• cfzjywxk
• sticnarf

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[sticnarf]

LGTM. But it's better to add a simple test.

[ekexium]

Hold this PR for now... We may not handle errors in this way.

[sre-bot]

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/2cf5a9a91135ff1870c40cd880238759ac9223b4

[ekexium]

Reviews are welcomed now.

[cfzjywxk]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 2cf5a9a

[hawkingrei]

/run-mysql-test

[sre-bot]

TiDB MergeCI notify

🔴 Bad News! [1] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name	Result	Duration	Compare with Parent commit
idc-jenkins-ci-tidb/tics-test	🔴 failed 1, success 0, total 1	7 min 20 sec	Existing failure
idc-jenkins-ci/integration-cdc-test	🟢 all 34 tests passed	29 min	Existing passed
idc-jenkins-ci-tidb/integration-common-test	🟢 all 11 tests passed	14 min	Existing passed
idc-jenkins-ci-tidb/integration-ddl-test	🟢 all 6 tests passed	10 min	Existing passed
idc-jenkins-ci-tidb/common-test	🟢 all 12 tests passed	7 min 8 sec	Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2	🟢 all 28 tests passed	7 min 7 sec	Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1	🟢 all 26 tests passed	7 min 7 sec	Existing passed
idc-jenkins-ci-tidb/mybatis-test	🟢 all 1 tests passed	4 min 4 sec	Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test	🟢 all 1 tests passed	3 min 1 sec	Existing passed
idc-jenkins-ci-tidb/plugin-test	🟢 build success, plugin test success	4min	Existing passed