-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backup: retry on internal error and make more errors can be retried (#34352) #34378
backup: retry on internal error and make more errors can be retried (#34352) #34378
Conversation
Signed-off-by: ti-srebot <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@3pointer you're already a collaborator in bot's repo. |
/run-integration-br-tests |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/616d885eb33e7b41f989b322f83df2679a38628e |
/run-integration-br-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 616d885
|
cherry-pick #34352 to release-5.4
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/34378
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #34350
Problem Summary:
This PR add will try retry as much as we can to improve robustness.
What is changed and how it works?
make more errors can be retryable( including internal error)
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.