Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: split and scatter regions in batches (#33625) #34258

Merged
merged 3 commits into from
Jun 27, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Apr 26, 2022

cherry-pick #33625 to release-5.4
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/34258

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/34258:release-5.4-2f2fa06c2fa5

What problem does this PR solve?

Issue Number: close #33618

Problem Summary:

Region scatter may timeout when split and scatter many regions at a time.

What is changed and how it works?

Add a batch limit for split and scatter regions. In a batch, lightning processes up to 4096 ranges. After all ranges in batch have been processed completely, lightning can process the next batch.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

I prepared about 1.8T data for a table which contains only one clustered primary key. TiDB cluster have ten TiKV nodes, each node have 200% cpu limit and 16GiB memory limit. Then I used lightning to import these data to TiDB cluster and observed the scatter operator status in grafana dashboard. To reproduce huge amount of regions, I set region-split-size to 8MiB. Finally, about 260k regions were created.

Master
image
Many scatter operator is timeout.

This PR
image

There is no operator timeout after this PR.

  • No code

Release note

lightning: split and scatter regions in batches

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 26, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • D3Hunter
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 26, 2022
@ti-srebot ti-srebot added component/lightning This issue is related to Lightning of TiDB. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/5.4-cherry-pick labels Apr 26, 2022
@ti-srebot ti-srebot added this to the v5.4.1 milestone Apr 26, 2022
@ti-srebot
Copy link
Contributor Author

@gozssky you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 27, 2022
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 27, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 23, 2022
@sleepymole
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b2449a1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 27, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jun 27, 2022
@sleepymole
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: dafee54

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 27, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 27, 2022

@ti-chi-bot ti-chi-bot merged commit d6be910 into pingcap:release-5.4 Jun 27, 2022
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Jun 27, 2022
@sleepymole sleepymole deleted the release-5.4-2f2fa06c2fa5 branch June 27, 2022 06:42
@heibaijian heibaijian modified the milestones: v5.4.1, v5.4.2 Jun 27, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/lightning This issue is related to Lightning of TiDB. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.4-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants