Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add a proposal for multi-schema change #34037

Merged
merged 32 commits into from
Jun 15, 2022
Merged

docs: add a proposal for multi-schema change #34037

merged 32 commits into from
Jun 15, 2022

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Apr 15, 2022 •
edited by bb7133
Loading

What problem does this PR solve?

Issue Number: ref #14766

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • NA

Documentation

  • NA

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 15, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • zimulala

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 15, 2022
@tangenta tangenta changed the title docs: add a proposal doc for multi-schema change docs: add a proposal for multi-schema change Apr 15, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 15, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/976f58233e0d1e9960e1bf5c5546816e2ce0deed

Defined2014
Defined2014 reviewed Apr 18, 2022
View reviewed changes
docs/design/2022-04-15-multi-schema-change.md Outdated Show resolved Hide resolved
docs/design/2022-04-15-multi-schema-change.md Outdated Show resolved Hide resolved
docs/design/2022-04-15-multi-schema-change.md Outdated Show resolved Hide resolved
docs/design/2022-04-15-multi-schema-change.md Outdated Show resolved Hide resolved
docs/design/2022-04-15-multi-schema-change.md Outdated Show resolved Hide resolved
@tangenta tangenta requested review from bb7133 and Defined2014 April 18, 2022 04:22
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 18, 2022
@tangenta tangenta mentioned this pull request Apr 18, 2022
Closed
@tangenta tangenta requested a review from bb7133 May 6, 2022 03:09
bb7133
bb7133 approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133
Copy link
Member

bb7133 commented Jun 15, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 699950f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 15, 2022
@ti-chi-bot ti-chi-bot merged commit cd51580 into pingcap:master Jun 15, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 15, 2022

TiDB MergeCI notify

🔴 Bad News! [1] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 2, success 9, total 11 21 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 34 tests passed 28 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 12 tests passed 11 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 6 min 3 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 0 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 47 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 17 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 9 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 2 min 58 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@tangenta tangenta mentioned this pull request Jul 28, 2022
Closed
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiongjiwei xiongjiwei xiongjiwei left review comments

@wjhuang2016 wjhuang2016 wjhuang2016 left review comments

@morgo morgo morgo left review comments

@Defined2014 Defined2014 Defined2014 approved these changes

@zimulala zimulala zimulala approved these changes

@bb7133 bb7133 bb7133 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@tangenta @ti-chi-bot @sre-bot @bb7133 @morgo @zimulala @wjhuang2016 @Defined2014 @xiongjiwei