Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: support index regions and updating the existed table rule when changing partition (#33925) #34025

Merged
merged 3 commits into from
Apr 28, 2022
Merged

ddl: support index regions and updating the existed table rule when changing partition (#33925) #34025

merged 3 commits into from
Apr 28, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Apr 15, 2022 •
edited
Loading

cherry-pick #33925 to release-5.4
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/34025

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tidb.git pr/34025:release-5.4-2810c1d55ddb

Signed-off-by: Ryan Leung [email protected]

What problem does this PR solve?

Issue Number: close #33929

Problem Summary: The table rule won't be updated when adding/dropping a partition.

What is changed and how it works?

This PR supports updating the existed table rules when adding or dropping a partition.

Check List

Tests

Release note

Fix the issue that the table attributes don't support index and won't be updated when the partition changes

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 15, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Apr 15, 2022
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 15, 2022
@ti-srebot ti-srebot mentioned this pull request Apr 15, 2022
Merged
4 tasks
@ti-srebot ti-srebot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/5.4-cherry-pick labels Apr 15, 2022
@ti-srebot
Copy link
Contributor Author

@rleungx you're already a collaborator in bot's repo.

@rleungx
Copy link
Member

rleungx commented Apr 26, 2022

/cc @xhebox @lcwangchao

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 26, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 27, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 27, 2022
@nolouch
Copy link
Member

nolouch commented Apr 27, 2022

/merge

@ti-chi-bot
Copy link
Member

@nolouch: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@AndreMouche
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7e6c4d72819a657f6f0bb8ec698fa89ee989da85

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 28, 2022
@nolouch
Copy link
Member

nolouch commented Apr 28, 2022

/run-unit-test

1 similar comment
@rleungx
Copy link
Member

rleungx commented Apr 28, 2022

/run-unit-test

@rleungx rleungx force-pushed the release-5.4-2810c1d55ddb branch from 83de36b to 0a3a40d Compare April 28, 2022 14:27
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 28, 2022
@disksing
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0a3a40d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 28, 2022
@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Contributor

sre-bot commented Apr 28, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/412d869fbd68d48e402e1a7b90596716b774c203

@ti-chi-bot ti-chi-bot merged commit 0ce2900 into pingcap:release-5.4 Apr 28, 2022
@purelind purelind added this to the v5.4.1 milestone Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolouch nolouch nolouch approved these changes

@xhebox xhebox xhebox approved these changes

@lcwangchao lcwangchao Awaiting requested review from lcwangchao

@Yisaer Yisaer Awaiting requested review from Yisaer

Assignees

@rleungx rleungx

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.4-cherry-pick
Projects
None yet
Milestone
v5.4.1
Development

Successfully merging this pull request may close these issues.
10 participants
@ti-srebot @ti-chi-bot @rleungx @nolouch @AndreMouche @disksing @sre-bot @xhebox @VelocityLight @purelind