Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: revert #27021 to fix a bug that selection can not be pushed down when having clause above aggregation #33168

Merged
merged 4 commits into from
Mar 17, 2022
Merged

*: revert #27021 to fix a bug that selection can not be pushed down when having clause above aggregation #33168

merged 4 commits into from
Mar 17, 2022
+21 −41

Conversation

wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Mar 16, 2022 •
edited
Loading

Signed-off-by: wjhuang2016 [email protected]

What problem does this PR solve?

Issue Number: close #33166

Problem Summary:
I don't know why #27021 get merged, but it's totally wrong.
First, selection can be pushed down when having clause above aggregation, it's true.
Second, the root cause of #26496 is the same as #30094, which is fixed by #30120

What is changed and how it works?

Revert #27021

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

fix a bug that selection can not be pushed down when having clause above aggregation

@wjhuang2016
done
821a50e 
Signed-off-by: wjhuang2016 <[email protected]>
@wjhuang2016 wjhuang2016 changed the title *: revert 27021 to fix a bug that selection can not be pushed down when having clause above aggregation *: revert #27021 to fix a bug that selection can not be pushed down when having clause above aggregation Mar 16, 2022
@ti-chi-bot ti-chi-bot added needs-cherry-pick-4.0 needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 16, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 16, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • guo-shaoge
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 16, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 16, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/269797f6665c71b6dd9ddaa43514fdc0abba5f8a

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 17, 2022
@wjhuang2016
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 269797f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 17, 2022
@ti-chi-bot ti-chi-bot merged commit 47e4b5b into pingcap:master Mar 17, 2022
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 17, 2022
@wjhuang2016 @ti-srebot
cherry pick pingcap#33168 to release-4.0
a7d79ba 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 17, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #33177

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 17, 2022
@wjhuang2016 @ti-srebot
cherry pick pingcap#33168 to release-5.0
1409422 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 17, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #33179

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 17, 2022
@wjhuang2016 @ti-srebot
cherry pick pingcap#33168 to release-5.1
26ec37b 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 17, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #33180

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 17, 2022
@wjhuang2016 @ti-srebot
cherry pick pingcap#33168 to release-5.2
680dcd3 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 17, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #33181

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 17, 2022
@wjhuang2016 @ti-srebot
cherry pick pingcap#33168 to release-5.3
22ed9aa 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 17, 2022
Closed
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.3 in PR #33183

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 17, 2022
@wjhuang2016 @ti-srebot
cherry pick pingcap#33168 to release-5.4
2c7f08e 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 17, 2022
Open
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.4 in PR #33186

@wjhuang2016 wjhuang2016 deleted the fix_regression_having_ppd branch November 17, 2022 11:17
@kennedy8312 kennedy8312 mentioned this pull request Mar 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@guo-shaoge guo-shaoge guo-shaoge approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

selection can not push down when having above agg
6 participants
@wjhuang2016 @ti-chi-bot @sre-bot @ti-srebot @guo-shaoge @winoros