Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bindinfo: refactor some codes in bindinfo package #33094

Merged
merged 3 commits into from
Mar 15, 2022
Merged

bindinfo: refactor some codes in bindinfo package #33094

merged 3 commits into from
Mar 15, 2022

Conversation

Reminiscent
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #32466

Problem Summary:

  1. rename some functions and comments from 'Using' to 'Enabled'
  2. update the status from 'Using' to 'Enabled' when upgrade
  3. improve the warning message

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@Reminiscent Reminiscent requested review from qw4990 and rebelice March 15, 2022 11:09
@Reminiscent Reminiscent requested a review from a team as a code owner March 15, 2022 11:09
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 15, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qw4990
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 15, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 15, 2022
@qw4990
Copy link
Contributor

qw4990 commented Mar 15, 2022

/run-unit-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 15, 2022
@qw4990
Copy link
Contributor

qw4990 commented Mar 15, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d9263bb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 15, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 15, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/d9263bb01478c39b643bd5e68f5159933b6a9f2b

@hawkingrei
Copy link
Member

/run-mysql-test

@qw4990 qw4990 merged commit e87bb52 into pingcap:master Mar 15, 2022
@morgo morgo mentioned this pull request Mar 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@time-and-fate time-and-fate time-and-fate approved these changes

@qw4990 qw4990 qw4990 approved these changes

@rebelice rebelice Awaiting requested review from rebelice

Assignees
No one assigned
Labels
component/bindinfo epic/sql-plan-management release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Reminiscent @ti-chi-bot @qw4990 @sre-bot @hawkingrei @time-and-fate