Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: ignore close-stmt to make more queries can hit plan cache #32928

Merged
merged 24 commits into from
Mar 15, 2022
Merged

planner: ignore close-stmt to make more queries can hit plan cache #32928

merged 24 commits into from
Mar 15, 2022

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Mar 8, 2022

What problem does this PR solve?

Issue Number: ref #31056

Problem Summary: planner: ignore close-stmt to make more queries can hit plan cache

What is changed and how it works?

planner: ignore close-stmt to make more queries can hit plan cache

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@qw4990 qw4990 requested a review from a team as a code owner March 8, 2022 13:53
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 8, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • rebelice

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 8, 2022
qw4990
qw4990 commented Mar 8, 2022
View reviewed changes
planner/core/prepare_test.go
tk.MustExec(`drop table if exists t`)
tk.MustExec(`create table t(a int, unique key(a))`)

// disable the ignore-stmt-cmd
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I check the binary protocol locally and it can work:
image

@sre-bot
Copy link
Contributor

sre-bot commented Mar 8, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/1b8200a4e3d6c5a495e3651413dc8f583b868c14

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 9, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 10, 2022
ngaut
ngaut reviewed Mar 13, 2022
View reviewed changes
session/session.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 13, 2022
@qw4990
Copy link
Contributor Author

qw4990 commented Mar 14, 2022

This PR is waiting for our regression test.

@qw4990
Copy link
Contributor Author

qw4990 commented Mar 14, 2022

This PR is waiting for our regression test.

We triggered Plan Cache PointGet Random Testing again and no regression related to this PR was found.

@qw4990
Copy link
Contributor Author

qw4990 commented Mar 14, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: fa33c93

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 14, 2022
@qw4990
Copy link
Contributor Author

qw4990 commented Mar 14, 2022

/run-unit-test

1 similar comment
@qw4990
Copy link
Contributor Author

qw4990 commented Mar 14, 2022

/run-unit-test

@qw4990
Copy link
Contributor Author

qw4990 commented Mar 14, 2022

/run-check_title

@qw4990
Copy link
Contributor Author

qw4990 commented Mar 14, 2022

/run-unit-test

@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2022
@qw4990
Copy link
Contributor Author

qw4990 commented Mar 15, 2022

/merge

@ti-chi-bot
Copy link
Member

@qw4990: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@qw4990 qw4990 merged commit 678397b into pingcap:master Mar 15, 2022
@qw4990 qw4990 mentioned this pull request May 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngaut ngaut ngaut left review comments

@Reminiscent Reminiscent Reminiscent approved these changes

@rebelice rebelice rebelice approved these changes

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@qw4990 @ti-chi-bot @sre-bot @ngaut @XuHuaiyu @rebelice @Reminiscent