Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: migrate test-infra to testify for add index tests #32864

Merged
merged 8 commits into from
Mar 7, 2022
Merged

ddl: migrate test-infra to testify for add index tests #32864

merged 8 commits into from
Mar 7, 2022

Conversation

tisonkun
Copy link
Contributor

@tisonkun tisonkun commented Mar 7, 2022

What problem does this PR solve?

Issue Number: close #32863

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 7, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • lcwangchao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 7, 2022
@tisonkun
Copy link
Contributor Author

tisonkun commented Mar 7, 2022 •
edited
Loading

/cc @hawkingrei @wjhuang2016

You can review this PR one commit by the other.

@hawkingrei
Copy link
Member

Have some test cases failed.

@hawkingrei
Copy link
Member

/run-unit-test

@sre-bot
Copy link
Contributor

sre-bot commented Mar 7, 2022

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/dc49745781b7f71e4bda550f735f14e850772f0b

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 7, 2022
@tisonkun
Copy link
Contributor Author

tisonkun commented Mar 7, 2022

/cc @xhebox @lcwangchao

@ti-chi-bot ti-chi-bot requested review from lcwangchao and xhebox March 7, 2022 08:32
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 7, 2022
@tisonkun
Copy link
Contributor Author

tisonkun commented Mar 7, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: dc49745

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 7, 2022
@hawkingrei
Copy link
Member

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit c9001b3 into pingcap:master Mar 7, 2022
@tisonkun tisonkun deleted the issue-32863 branch March 7, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@lcwangchao lcwangchao lcwangchao approved these changes

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

@xhebox xhebox Awaiting requested review from xhebox

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for add index tests
5 participants
@tisonkun @ti-chi-bot @hawkingrei @sre-bot @lcwangchao