-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
table/tables: fix buildListColumnsPruner issue in the list partition #32621
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
5f0b870
to
3995ef8
Compare
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/8641ef28de75aea8f1e72588fec9fd7c09f42cac |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 3995ef8
|
/run-unit-test |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.0 in PR #32768 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.1 in PR #32769 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.2 in PR #32770 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.3 in PR #32771 |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-5.4 in PR #32772 |
What problem does this PR solve?
Issue Number: close #32416
Problem Summary:
This also affects the master. This problem can also occur in the following scenario:
The above scenario is analyzed in detail:
In step 1
In the bootstrap phase, new collation is true
After bootstrap ends, new collation is false.
In step 2
EncodeKey
) in TableFromMetaEncodeKey
) could not be found in the hashMap.What is changed and how it works?
Instead of creating the hashMap in the
TableFromMeta
phase( In the bootstrap phase), we create the hashMap on a delayed basis (that is, when a partition needs to be located).In this way,
new_collations_enabled_on_first_bootstrap
does not have inconsistency problems.Check List
Tests
new_collations_enabled_on_first_bootstrap
item to false and run the SQL statements as follows:new_collations_enabled_on_first_bootstrap = false
and execute the following statements:The above scenario is analyzed in detail:
Side effects
Documentation
Release note