Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: support push bit column down to TiKV #32497

Merged
merged 36 commits into from
Mar 1, 2022
Merged

expression: support push bit column down to TiKV #32497

merged 36 commits into from
Mar 1, 2022

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Feb 21, 2022

What problem does this PR solve?

Issue Number: close #30738

Problem Summary:

What is changed and how it works?

Support push bit column down to TiKV

Check List

Tests

  • Unit test
  • Integration test

Release note

None

xiejiandong and others added 29 commits January 21, 2022 15:15
Bit column support push down to TiKV;
ae306b9 
Signed-off-by: xiejiandong <[email protected]>
Merge branch 'pingcap:master' into master
ced1b5a
copr: Bit column support push down to TiKV(pingcap#30738)
2be25de 
Signed-off-by: xiejiandong <[email protected]>
Merge branch 'master' of https://github.com/xiejiandong/tidb
3127615
@hawkingrei
Merge branch 'master' into master
44d310f
copr: Bit column support push down to TiKV: support cast/ascii/binary…
2d24e20 
… etc.(pingcap#30738)

Signed-off-by: xiejiandong <[email protected]>
Merge branch 'master' of https://github.com/xiejiandong/tidb
3fbbd5e
Merge branch 'pingcap:master' into master
9c72109
copr: Bit column support push down to TiKV, add test.(pingcap#30738)
7aaf62e 
Signed-off-by: xiejiandong <[email protected]>
Merge branch 'master' of https://github.com/xiejiandong/tidb
014c448
copr: Bit column support push down to TiKV, add test.(pingcap#30738)
fb0c78b 
Signed-off-by: xiejiandong <[email protected]>
Merge branch 'pingcap:master' into master
7c54b11
Merge branch 'pingcap:master' into master
9179639
gofmt update.
7d1368a 
Signed-off-by: xiejiandong <[email protected]>
Merge branch 'master' into master
8df7931
Merge branch 'master' into master
d5e0aee
Merge branch 'pingcap:master' into master
940af02
Merge branch 'master' into master
ee268af
Merge branch 'master' into master
d230c30
@Yisaer
fix test
bf39c0e 
Signed-off-by: yisaer <[email protected]>
@Yisaer
change to mysqlbit
a728df9 
Signed-off-by: yisaer <[email protected]>

fix

Signed-off-by: yisaer <[email protected]>
@Yisaer
add testcase
46bf81a 
Signed-off-by: yisaer <[email protected]>
@Yisaer
Revert "add testcase"
2b9c78e 
This reverts commit 46bf81a.
@Yisaer
Revert "change to mysqlbit"
a0dd6e2 
This reverts commit a728df9.
@Yisaer
fix test
3386f4f 
Signed-off-by: yisaer <[email protected]>
@Yisaer
remove flen tmp
08091cf 
Signed-off-by: yisaer <[email protected]>
@Yisaer
fix flen
5dba789 
Signed-off-by: yisaer <[email protected]>
@Yisaer
fix flen
6ab868e 
Signed-off-by: yisaer <[email protected]>
@Yisaer
Merge remote-tracking branch 'upstream/master' into bit-push-down-2
d56dbc0
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 21, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • LittleFall
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@Yisaer Yisaer requested a review from winoros February 22, 2022 03:00
@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 24, 2022
@Yisaer Yisaer mentioned this pull request Feb 24, 2022
Merged
@Yisaer
Copy link
Contributor Author

Yisaer commented Feb 24, 2022

hold until tikv/tikv#12016 merged

@Yisaer
fix conflict
7f868fb 
Signed-off-by: yisaer <[email protected]>
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 1, 2022
@Yisaer Yisaer requested a review from rebelice March 1, 2022 05:46
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 1, 2022
@Yisaer
Copy link
Contributor Author

Yisaer commented Mar 1, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7f868fb

@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 1, 2022
@ti-chi-bot ti-chi-bot removed status/can-merge Indicates a PR has been approved by a committer. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 1, 2022
@Yisaer
Copy link
Contributor Author

Yisaer commented Mar 1, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a228855

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 1, 2022
@Yisaer
Copy link
Contributor Author

Yisaer commented Mar 1, 2022

/run-unit-test

1 similar comment
@Yisaer
Copy link
Contributor Author

Yisaer commented Mar 1, 2022

/run-unit-test

@Yisaer
Copy link
Contributor Author

Yisaer commented Mar 1, 2022

/run-unit-test

2 similar comments
@Yisaer
Copy link
Contributor Author

Yisaer commented Mar 1, 2022

/run-unit-test

@Yisaer
Copy link
Contributor Author

Yisaer commented Mar 1, 2022

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit fbfe36c into pingcap:master Mar 1, 2022
@windtalker windtalker mentioned this pull request Feb 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LittleFall LittleFall LittleFall approved these changes

@winoros winoros winoros approved these changes

@rebelice rebelice Awaiting requested review from rebelice

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The predicate on the bit column cannot be pushed down
6 participants
@Yisaer @ti-chi-bot @sre-bot @winoros @LittleFall @hawkingrei